From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeff McGee <jeff.mcgee@intel.com>
Subject: Re: [PATCH 3/3] tests/pm_rps: load harder
Date: Fri, 14 Mar 2014 09:41:13 -0500
Message-ID: <20140314144112.GC5686@jeffdesk>
References: <1394789268-28703-1-git-send-email-daniel.vetter@ffwll.ch>
	<1394789268-28703-3-git-send-email-daniel.vetter@ffwll.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
	by gabe.freedesktop.org (Postfix) with ESMTP id 132C3FACEC
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 14 Mar 2014 07:34:35 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1394789268-28703-3-git-send-email-daniel.vetter@ffwll.ch>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Fri, Mar 14, 2014 at 10:27:48AM +0100, Daniel Vetter wrote:
> Big core platforms need some seriuos omph to break a sweat.
> 
> This fixes min-max-config-loaded here on my ivb.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=75146
> Cc: Jeff McGee <jeff.mcgee@intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
>  tests/pm_rps.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/tests/pm_rps.c b/tests/pm_rps.c
> index fc6bac647f4a..b5dd494443ff 100644
> --- a/tests/pm_rps.c
> +++ b/tests/pm_rps.c
> @@ -156,6 +156,7 @@ static struct load_helper {
>  	enum load load;
>  	bool exit;
>  	struct igt_helper_process igt_proc;
> +	drm_intel_bo *src, *dst;
>  } lh;
>  
>  static void load_helper_signal_handler(int sig)
> @@ -195,6 +196,7 @@ static void emit_store_dword_imm(uint32_t val)
>  }
>  
>  #define LOAD_HELPER_PAUSE_USEC 500
> +#define LOAD_HELPER_BO_SIZE (16*1024*1024)
>  static void load_helper_set_load(enum load load)
>  {
>  	assert(lh.igt_proc.running);
> @@ -226,6 +228,10 @@ static void load_helper_run(enum load load)
>  		signal(SIGUSR2, load_helper_signal_handler);
>  
>  		while (!lh.exit) {
> +			if (lh.load == HIGH)
> +				intel_copy_bo(lh.batch, lh.dst, lh.dst,
> +					      LOAD_HELPER_BO_SIZE);
> +
Did you mean to use lh.src here?
>  			emit_store_dword_imm(val);
>  			intel_batchbuffer_flush_on_ring(lh.batch, 0);
>  			val++;
> @@ -270,6 +276,13 @@ static void load_helper_init(void)
>  	lh.target_buffer = drm_intel_bo_alloc(lh.bufmgr, "target bo",
>  					      4096, 4096);
>  	igt_assert(lh.target_buffer);
> +
> +	lh.dst = drm_intel_bo_alloc(lh.bufmgr, "dst bo",
> +				    LOAD_HELPER_BO_SIZE, 4096);
> +	igt_assert(lh.dst);
> +	lh.src = drm_intel_bo_alloc(lh.bufmgr, "src bo",
> +				    LOAD_HELPER_BO_SIZE, 4096);
> +	igt_assert(lh.src);
>  }
>  
>  static void load_helper_deinit(void)
Should we free these in load_helper_deinit?
> -- 
> 1.8.4.rc3
>