From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Arnd Bergmann To: Catalin Marinas Subject: Re: [PATCH v7 3/3] arm64: Add architecture support for PCI Date: Fri, 14 Mar 2014 18:38:08 +0100 Cc: Liviu Dudau , "linux-pci" , Bjorn Helgaas , Will Deacon , Benjamin Herrenschmidt , "linaro-kernel" , LKML , "devicetree@vger.kernel.org" , LAKML , Tanmay Inamdar , Grant Likely References: <1394811258-1500-1-git-send-email-Liviu.Dudau@arm.com> <1394811258-1500-4-git-send-email-Liviu.Dudau@arm.com> <20140314171457.GK18126@arm.com> In-Reply-To: <20140314171457.GK18126@arm.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Message-Id: <201403141838.08900.arnd@arndb.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: On Friday 14 March 2014, Catalin Marinas wrote: > On Fri, Mar 14, 2014 at 03:34:18PM +0000, Liviu Dudau wrote: > > --- /dev/null > > +++ b/arch/arm64/kernel/pci.c > [...] > > +int pci_register_io_range(phys_addr_t address, resource_size_t size) > [...] > > +unsigned long pci_address_to_pio(phys_addr_t address) > [...] > > +void pcibios_fixup_bus(struct pci_bus *bus) > [ actually most of this file ] > > Maybe it was raised before already but can we have __weak generic > definitions of these functions? They don't seem to be arm64 specific in > any way. > I would definitely prefer that. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Fri, 14 Mar 2014 18:38:08 +0100 Subject: [PATCH v7 3/3] arm64: Add architecture support for PCI In-Reply-To: <20140314171457.GK18126@arm.com> References: <1394811258-1500-1-git-send-email-Liviu.Dudau@arm.com> <1394811258-1500-4-git-send-email-Liviu.Dudau@arm.com> <20140314171457.GK18126@arm.com> Message-ID: <201403141838.08900.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Friday 14 March 2014, Catalin Marinas wrote: > On Fri, Mar 14, 2014 at 03:34:18PM +0000, Liviu Dudau wrote: > > --- /dev/null > > +++ b/arch/arm64/kernel/pci.c > [...] > > +int pci_register_io_range(phys_addr_t address, resource_size_t size) > [...] > > +unsigned long pci_address_to_pio(phys_addr_t address) > [...] > > +void pcibios_fixup_bus(struct pci_bus *bus) > [ actually most of this file ] > > Maybe it was raised before already but can we have __weak generic > definitions of these functions? They don't seem to be arm64 specific in > any way. > I would definitely prefer that. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v7 3/3] arm64: Add architecture support for PCI Date: Fri, 14 Mar 2014 18:38:08 +0100 Message-ID: <201403141838.08900.arnd@arndb.de> References: <1394811258-1500-1-git-send-email-Liviu.Dudau@arm.com> <1394811258-1500-4-git-send-email-Liviu.Dudau@arm.com> <20140314171457.GK18126@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140314171457.GK18126@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Catalin Marinas Cc: "devicetree@vger.kernel.org" , linaro-kernel , linux-pci , Liviu Dudau , LKML , Will Deacon , Grant Likely , Tanmay Inamdar , Benjamin Herrenschmidt , Bjorn Helgaas , LAKML List-Id: devicetree@vger.kernel.org On Friday 14 March 2014, Catalin Marinas wrote: > On Fri, Mar 14, 2014 at 03:34:18PM +0000, Liviu Dudau wrote: > > --- /dev/null > > +++ b/arch/arm64/kernel/pci.c > [...] > > +int pci_register_io_range(phys_addr_t address, resource_size_t size) > [...] > > +unsigned long pci_address_to_pio(phys_addr_t address) > [...] > > +void pcibios_fixup_bus(struct pci_bus *bus) > [ actually most of this file ] > > Maybe it was raised before already but can we have __weak generic > definitions of these functions? They don't seem to be arm64 specific in > any way. > I would definitely prefer that. Arnd