From: Veaceslav Falico <vfalico@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, fubar@us.ibm.com, andy@greyhouse.net
Subject: Re: [PATCH net-next 2/2] bonding: use the correct ether type for alb
Date: Fri, 14 Mar 2014 19:42:52 +0100 [thread overview]
Message-ID: <20140314184251.GA30498@redhat.com> (raw)
In-Reply-To: <20140314.142935.1237930025090619830.davem@davemloft.net>
On Fri, Mar 14, 2014 at 02:29:35PM -0400, David Miller wrote:
>From: Veaceslav Falico <vfalico@redhat.com>
>Date: Thu, 13 Mar 2014 12:41:58 +0100
>
>> @@ -1005,7 +1005,7 @@ static void alb_send_lp_vid(struct slave *slave, u8 mac_addr[],
>> memset(&pkt, 0, size);
>> ether_addr_copy(pkt.mac_dst, mac_addr);
>> ether_addr_copy(pkt.mac_src, mac_addr);
>> - pkt.type = cpu_to_be16(ETH_P_LOOP);
>> + pkt.type = cpu_to_be16(ETH_P_LOOPBACK);
>
>Had this really never worked properly at all?
Yep, but only in cases where the hw/sw didn't filter out broken packets
*before* arp processing, as far as I can tell.
>
>It's been this way since the beginning of GIT history, and I imagine
>since the learning packet code even existed.
next prev parent reply other threads:[~2014-03-14 18:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-13 11:41 [PATCH net-next 0/2] bonding: use correct ether type for alb Veaceslav Falico
2014-03-13 11:41 ` [PATCH net-next 1/2] ether: add loopback type ETH_P_LOOPBACK Veaceslav Falico
2014-03-13 11:41 ` [PATCH net-next 2/2] bonding: use the correct ether type for alb Veaceslav Falico
2014-03-14 18:29 ` David Miller
2014-03-14 18:42 ` Veaceslav Falico [this message]
2014-03-14 19:12 ` David Miller
2014-03-14 19:27 ` Jay Vosburgh
2014-03-14 19:47 ` Veaceslav Falico
2014-03-15 2:21 ` [PATCH net-next 0/2] bonding: use " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140314184251.GA30498@redhat.com \
--to=vfalico@redhat.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.