From: "John W. Linville" <linville@tuxdriver.com>
To: Dan Williams <dcbw@redhat.com>
Cc: fariyaf@gmail.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v4 00/11] rsi: Adding RS9113 wireless driver.
Date: Fri, 14 Mar 2014 15:26:04 -0400 [thread overview]
Message-ID: <20140314192604.GF20339@tuxdriver.com> (raw)
In-Reply-To: <1394823891.5829.14.camel@dcbw.local>
On Fri, Mar 14, 2014 at 02:04:51PM -0500, Dan Williams wrote:
> On Mon, 2014-03-10 at 20:56 +0530, fariyaf@gmail.com wrote:
> > From: Fariya Fatima <fariyaf@gmail.com>
> >
> > This series of patches adds Redpine Signals wireless driver.
>
> Looking much better, good work.
>
> One last comment; there are a couple functions (rsi_device_init,
> rsi_host_intf_write_pkt) that are defined multiple times, once in the
> USB code and once in the SDIO code. These need to be renamed, otherwise
> you will not be able to load the USB and the SDIO modules at the same
> time.
>
> I would suggest making all the functions in rsi_usb.h start with
> "rsi_usb" if they don't already, and have functions in rsi_sdio.h start
> with "rsi_sdio" if they don't already.
Good thing I haven't pushed yet... :-)
Please make the changes Dan suggests and resubmit...thanks!
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2014-03-14 19:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-10 15:26 [PATCH v4 00/11] rsi: Adding RS9113 wireless driver fariyaf
2014-03-10 15:26 ` [PATCH v4 01/11] rsi: Adding RS9113 driver header files fariyaf
2014-03-10 15:26 ` [PATCH v4 02/11] rsi: Adding remaining " fariyaf
2014-03-10 15:26 ` [PATCH v4 03/11] rsi: Adding core and main files fariyaf
2014-03-10 15:26 ` [PATCH v4 04/11] rsi: Writing packets to device and debugfs fariyaf
2014-03-10 15:26 ` [PATCH v4 05/11] rsi: MAC80211 callbacks to driver fariyaf
2014-03-10 15:26 ` [PATCH v4 06/11] rsi: MAC80211 callbacks and management functions internal to device fariyaf
2014-03-10 15:26 ` [PATCH v4 07/11] rsi: Management functions internal to the device fariyaf
2014-03-10 15:26 ` [PATCH v4 08/11] rsi: USB functionality fariyaf
2014-03-10 15:26 ` [PATCH v4 09/11] rsi: SDIO functionality fariyaf
2014-03-10 15:26 ` [PATCH v4 10/11] rsi: Remaining " fariyaf
2014-03-10 15:26 ` [PATCH v4 11/11] rsi: Makefile and Kconfig fariyaf
2014-03-14 19:04 ` [PATCH v4 00/11] rsi: Adding RS9113 wireless driver Dan Williams
2014-03-14 19:26 ` John W. Linville [this message]
2014-03-14 19:23 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140314192604.GF20339@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=dcbw@redhat.com \
--cc=fariyaf@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.