From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] mmc: Remove ops from struct mmc and put in mmc_ops
Date: Sat, 15 Mar 2014 00:10:15 +0100 [thread overview]
Message-ID: <201403150010.15458.marex@denx.de> (raw)
In-Reply-To: <CAPnjgZ3aOP+9r_ZN=_LfiTCwZtB=qCjM1U-9Xvr8ZoymrfQdZA@mail.gmail.com>
On Friday, March 14, 2014 at 09:53:51 PM, Simon Glass wrote:
> Hi,
>
> On 12 March 2014 04:24, Pantelis Antoniou <panto@antoniou-consulting.com>
wrote:
> > Remove the in-structure ops and put them in mmc_ops with
> > a constant pointer to it.
> >
> > This makes the mmc structure smaller as well as conserving
> > code space (in theory).
>
> You might be able to run buildman (and use -S) to check this.
>
> These changes look good to me, and will make it easier to move to
> driver model I suspect.
Full ack on the driver model part.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2014-03-14 23:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-12 10:24 [U-Boot] [PATCH 0/3] mmc: Cleanup time for mmc_struct Pantelis Antoniou
2014-03-12 10:24 ` [U-Boot] [PATCH 1/3] mmc: Remove ops from struct mmc and put in mmc_ops Pantelis Antoniou
2014-03-14 20:53 ` Simon Glass
2014-03-14 23:10 ` Marek Vasut [this message]
2014-03-12 10:24 ` [U-Boot] [PATCH 2/3] mmc: Convert mmc struct's name array to a pointer Pantelis Antoniou
2014-03-14 20:55 ` Simon Glass
2014-03-14 23:10 ` Marek Vasut
2014-03-12 10:24 ` [U-Boot] [PATCH 3/3] mmc: Split mmc struct, rework mmc initialization Pantelis Antoniou
2014-03-14 20:56 ` Simon Glass
2014-03-12 11:32 ` [U-Boot] [PATCH 0/3] mmc: Cleanup time for mmc_struct Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201403150010.15458.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.