From: Rakesh Pandit <rakesh@tuxera.com>
To: <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] Btrfs-progs: scrub: don't call unlock if pthread_mutex_lock fails
Date: Sat, 15 Mar 2014 02:29:33 +0200 [thread overview]
Message-ID: <20140315002933.GA29539@localhost.localdomain> (raw)
In-Reply-To: <20140314234943.GA28451@localhost.localdomain>
Hi,
Forgot to mention the reason for change. If accepted this can be
included in commit message:
On Sat, Mar 15, 2014 at 01:49:45AM +0200, Rakesh Pandit wrote:
> If pthread_mutex_lock fails (rare but fix it anyway), don't call
> pthread_mutex_unlock on mutex.
>
Rationale being that if pthread_mutex_lock fails pthread_mutex_unlock
will always fail and overwrite actual error value in err.
> Signed-off-by: Rakesh Pandit <rakesh@tuxera.com>
regards,
next prev parent reply other threads:[~2014-03-15 0:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-14 23:49 [PATCH] Btrfs-progs: scrub: don't call unlock if pthread_mutex_lock fails Rakesh Pandit
2014-03-15 0:29 ` Rakesh Pandit [this message]
2014-03-17 12:44 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140315002933.GA29539@localhost.localdomain \
--to=rakesh@tuxera.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.