From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41602) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WPIYA-0008S2-PX for qemu-devel@nongnu.org; Sun, 16 Mar 2014 17:24:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WPIY4-0007JJ-5B for qemu-devel@nongnu.org; Sun, 16 Mar 2014 17:24:54 -0400 Received: from mail-oa0-f52.google.com ([209.85.219.52]:41778) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WPIY4-0007JC-0J for qemu-devel@nongnu.org; Sun, 16 Mar 2014 17:24:48 -0400 Received: by mail-oa0-f52.google.com with SMTP id l6so4850429oag.11 for ; Sun, 16 Mar 2014 14:24:47 -0700 (PDT) Date: Sun, 16 Mar 2014 21:23:44 +0000 From: Leandro Dorileo Message-ID: <20140316212344.GB23454@dorilex> References: <1394304438-14848-1-git-send-email-l@dorileo.org> <20140311110616.GD3215@dhcp-200-207.str.redhat.com> <20140311140918.GA30837@dorilex> <531F2A4E.7080508@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <531F2A4E.7080508@redhat.com> Subject: Re: [Qemu-devel] [PATCH RFC 0/2] qemu-arg: general purpose argument parser List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Kevin Wolf , Peter Maydell , Fam Zheng , Stefan Weil , Michael Tokarev , qemu-devel@nongnu.org, Stefan Hajnoczi , Paolo Bonzini , Laszlo Ersek , Peter Lieven Hi Erick, On Tue, Mar 11, 2014 at 09:22:54AM -0600, Eric Blake wrote: > On 03/11/2014 08:09 AM, Leandro Dorileo wrote: > > Hi Kevin, > > > > On Tue, Mar 11, 2014 at 12:06:16PM +0100, Kevin Wolf wrote: > >> Am 08.03.2014 um 19:47 hat Leandro Dorileo geschrieben: > >>> The following patchset introduces a general purpose argument parser and migrates > >>> qemu-img to make use of it. qemu-img is just the first user of it, if we see a > >>> good feedback here I move forward and migrate all the other possible users. > >> > >> I was planning to reply to this in more detail, but it doesn't look like > >> I can find the time to do so, so let me just summarise my thoughts > >> briefly. > > > > Ok. > > > >> > >> I do like the idea of simplifying qemu-img's argument parsing, but we > >> shouldn't make the mistake of introducing another option parsing > >> infrastructure and end up with three different coexisting models. If we > >> were to introduce a new framework, we must make sure that all code is > >> converted to it and QemuOpts can be dropped. > > > > Agreed. > > For that matter, if you want to help the current conversion efforts > going on, we are trying to get rid of QEMUOptionParameters to _just_ use > QemuOpts: > https://lists.gnu.org/archive/html/qemu-devel/2014-03/msg01728.html Yep sure, I have followed the current patches and reviews, I have just posted a patch with an initial testsuite for QemuOpt in the sense to help to have it integrated. > > > >> > >> We would probably need to add a new parser to QemuOpts that parses > >> command line options into a QemuOpts, and extend the definition of them > >> with a couple of new features that are required there (sub-QemuOpts for > >> -o, perhaps enumerations for things like --output=human/json, positional > >> parameters). > > > > Ok. > > We also need to think how to expose those improvements via the QMP > command query-command-line-arguments; lots of details in this thread: > https://lists.gnu.org/archive/html/qemu-devel/2014-03/threads.html#00934 Will take a look at it. Thanks... -- Leandro Dorileo