From: Stephen Hemminger <stephen@networkplumber.org>
To: Byungho An <bh74.an@samsung.com>
Cc: 'Francois Romieu' <romieu@fr.zoreil.com>,
netdev@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
davem@davemloft.net, ilho215.lee@samsung.com,
siva.kallam@samsung.com, vipul.pandya@samsung.com,
ks.giri@samsung.com, 'Joe Perches' <joe@perches.com>
Subject: Re: [PATCH V2 RE-SEND 1/7] net: sxgbe: add basic framework for Samsung 10Gb ethernet driver
Date: Mon, 17 Mar 2014 09:58:53 -0700 [thread overview]
Message-ID: <20140317095853.27c27f6c@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <005601cf4194$752c0c60$5f842520$@samsung.com>
On Sun, 16 Mar 2014 20:53:25 -0700
Byungho An <bh74.an@samsung.com> wrote:
> >
> > They are used but they always point to the same set of methods.
> > Those methods could thus be directly called.
> Yes, those methods can be called directly.
> But I think it is acceptable for manageability and extension for future.
That argument is only valid if:
1. you have hardware that will use it but it is not ready.
2. they will get used in next release (in < 6 mo)
Ths set of indirection has negative cost: it impedes readability,
has to be maintained, and hurts performance.
One of the principles of agile programming is NOT to build infrastructure
until it is needed. Otherwise you are likely to build it wrong.
next prev parent reply other threads:[~2014-03-17 16:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-13 6:55 [PATCH V2 RE-SEND 1/7] net: sxgbe: add basic framework for Samsung 10Gb ethernet driver Byungho An
2014-03-13 12:53 ` Joe Perches
2014-03-13 13:02 ` Joe Perches
2014-03-14 0:44 ` Francois Romieu
2014-03-16 0:09 ` Andrew.an
2014-03-16 23:11 ` Francois Romieu
2014-03-17 3:53 ` Byungho An
2014-03-17 16:58 ` Stephen Hemminger [this message]
2014-03-17 17:38 ` Byungho An
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140317095853.27c27f6c@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber.org \
--cc=bh74.an@samsung.com \
--cc=davem@davemloft.net \
--cc=ilho215.lee@samsung.com \
--cc=joe@perches.com \
--cc=ks.giri@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
--cc=siva.kallam@samsung.com \
--cc=vipul.pandya@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.