From: Oleg Nesterov <oleg@redhat.com>
To: Peter Hurley <peter@hurleysoftware.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Sree Harsha Totakura <sreeharsha@totakura.in>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
"Eric W. Biederman" <ebiederm@xmission.com>,
Jeff Dike <jdike@addtoit.com>, Ingo Molnar <mingo@elte.hu>
Subject: [PATCH 0/2] (Was: pppd service crash in linux-3.13.6)
Date: Mon, 17 Mar 2014 19:04:16 +0100 [thread overview]
Message-ID: <20140317180416.GA15708@redhat.com> (raw)
In-Reply-To: <53244C61.5090508@hurleysoftware.com>
On 03/15, Peter Hurley wrote:
>
> On 03/14/2014 05:04 PM, Oleg Nesterov wrote:
>>
>> But it can't even know who called call_usermodehelper(). Besides,
>> cgroup_release_agent() uses UMH_WAIT_EXEC, so the caller can continue
>> and disappear completely before the usermode process has any chance
>> to do something.
>
> I'm just hypothesizing potential breakage, since the order of teardown
> is sensitive to changes, and I didn't do a complete audit of all the
> possibilities.
Yes, I understand your concerns. Still I do not see how cgroup_exit()
can depend on tty/namespace.
> If you feel strongly about moving disassociate_tty(), I won't object.
It is not that I feel really strongly... just in looks better to me.
If nothing else:
1. If we actually can not do disassociate_ctty() before, say,
cgroup_exit(), then we should understand and document the
reason.
2. task_work_add() can have more users in drivers/tty which
can be triggered by disassociate_tty() paths. So I think
it would be nice to call it before task_work_exit().
2/2 is offtopic and hopefully trivial.
Oleg.
next prev parent reply other threads:[~2014-03-17 18:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-07 21:19 pppd service crash in linux-3.13.6 Sree Harsha Totakura
2014-03-10 16:56 ` Sree Harsha Totakura
2014-03-10 19:23 ` Peter Hurley
2014-03-13 17:06 ` Oleg Nesterov
2014-03-13 17:55 ` Peter Hurley
2014-03-14 14:19 ` Peter Hurley
2014-03-14 15:02 ` Peter Hurley
2014-03-14 19:23 ` Oleg Nesterov
2014-03-14 20:28 ` Peter Hurley
2014-03-14 21:04 ` Oleg Nesterov
2014-03-15 12:49 ` Peter Hurley
2014-03-17 18:04 ` Oleg Nesterov [this message]
2014-03-17 18:04 ` [PATCH 1/2] exit: call disassociate_ctty() before exit_task_namespaces() Oleg Nesterov
2014-03-17 18:05 ` [PATCH 2/2] exit: move check_stack_usage() to the end of do_exit() Oleg Nesterov
2014-03-10 19:54 ` pppd service crash in linux-3.13.6 Ben Hutchings
2014-03-12 21:25 ` Sree Harsha Totakura
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140317180416.GA15708@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
--cc=peter@hurleysoftware.com \
--cc=sreeharsha@totakura.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.