From: Uwe Storbeck <uwe@ibr.ch>
To: git@vger.kernel.org
Subject: [PATCH v2] test-lib.sh: use printf instead of echo
Date: Mon, 17 Mar 2014 19:39:17 +0100 [thread overview]
Message-ID: <20140317183917.GA28675@ibr.ch> (raw)
In-Reply-To: <20140314235735.GA6959@ibr.ch>
when variables may contain backslash sequences.
Backslash sequences are interpreted as control characters
by the echo command of some shells (e.g. dash).
Signed-off-by: Uwe Storbeck <uwe@ibr.ch>
---
Changed $@ to $* in printf.
Thanks to Johannes Sixt to point that out.
t/test-lib.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/test-lib.sh b/t/test-lib.sh
index 1531c24..3c7cb1d 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -277,7 +277,7 @@ error "Test script did not set test_description."
if test "$help" = "t"
then
- echo "$test_description"
+ printf '%s\n' "$test_description"
exit 0
fi
@@ -328,7 +328,7 @@ test_failure_ () {
test_failure=$(($test_failure + 1))
say_color error "not ok $test_count - $1"
shift
- echo "$@" | sed -e 's/^/# /'
+ printf '%s\n' "$*" | sed -e 's/^/# /'
test "$immediate" = "" || { GIT_EXIT_OK=t; exit 1; }
}
--
1.9.0
next prev parent reply other threads:[~2014-03-17 18:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-14 23:57 [PATCH] test-lib.sh: use printf instead of echo Uwe Storbeck
2014-03-15 0:18 ` Jonathan Nieder
2014-03-17 19:26 ` Junio C Hamano
2014-03-18 22:18 ` Jonathan Nieder
2014-03-19 17:17 ` Junio C Hamano
2014-03-19 17:22 ` David Kastrup
2014-03-19 19:24 ` Junio C Hamano
2014-03-20 0:17 ` Jonathan Nieder
2014-03-20 16:42 ` Junio C Hamano
2014-03-15 8:59 ` Johannes Sixt
2014-03-17 18:38 ` Uwe Storbeck
2014-03-17 18:39 ` Uwe Storbeck [this message]
2014-03-18 0:14 ` [PATCH v3] test-lib.sh: do not "echo" externally supplied strings Uwe Storbeck
2014-03-18 18:47 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140317183917.GA28675@ibr.ch \
--to=uwe@ibr.ch \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.