From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Snitzer Subject: Re: [PATCH 2/6] dm: introduce dm_accept_partial_bio Date: Mon, 17 Mar 2014 15:09:07 -0400 Message-ID: <20140317190907.GA3269@redhat.com> References: <20140317132740.GA7184@redhat.com> <20140317174324.GA2285@redhat.com> Reply-To: device-mapper development Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20140317174324.GA2285@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Mikulas Patocka Cc: dm-devel@redhat.com, Edward Thornber , "Alasdair G. Kergon" List-Id: dm-devel.ids On Mon, Mar 17 2014 at 1:43pm -0400, Mike Snitzer wrote: > On Mon, Mar 17 2014 at 1:08pm -0400, > Mikulas Patocka wrote: > > > > > Regarding REQ_FLUSH - it would already crash on NULL pointer dereference > > when accessing *tio->len_ptr. I realize if any of these BUG_ON checks hits the calling target code has a bug. I just think it a fairly harsh response to BUG the system. But I can let this issue go. I do however want you to add yet another BUG_ON for any bio that isn't meant to be sent to this interface (only one so far is REQ_FLUSH AFAIK).