From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH] drm/imx: remove drm_mode_connector_detach_encoder harder Date: Mon, 17 Mar 2014 14:48:56 -0700 Message-ID: <20140317214856.GA22663@kroah.com> References: <1394533830-30150-1-git-send-email-daniel.vetter@ffwll.ch> <1394882149-5029-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) by gabe.freedesktop.org (Postfix) with ESMTP id 735206F5AC for ; Mon, 17 Mar 2014 14:46:55 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1394882149-5029-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: Russell King , DRI Development List-Id: dri-devel@lists.freedesktop.org On Sat, Mar 15, 2014 at 12:15:49PM +0100, Daniel Vetter wrote: > Since the last time I've looked more of this stuff sprouted up. Stomp > it down again. > > Repeating the original justification for ripping this all out: There's > absolutely no need to deteach connectors before cleaning them up at > driver unload time. And since drm doesn't support hotplugging kms > objects at all it's positively dangerous to attempt this at runtime. > Luckily imx only detachs at driver cleanup time and hence we can > savely remove this. > > Reported-by: kbuild test robot > Cc: Sascha Hauer > Cc: Russell King > Cc: Greg Kroah-Hartman > Signed-off-by: Daniel Vetter > --- > drivers/staging/imx-drm/imx-hdmi.c | 1 - > drivers/staging/imx-drm/imx-tve.c | 2 -- > 2 files changed, 3 deletions(-) Acked-by: Greg Kroah-Hartman