From: Markus Pargmann <mpa@pengutronix.de>
To: Tony Lindgren <tony@atomide.com>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
linux-omap@vger.kernel.org, Mark Brown <broonie@linaro.org>
Subject: Re: OMAP4 SDP regression...
Date: Tue, 18 Mar 2014 08:59:35 +0100 [thread overview]
Message-ID: <20140318075935.GG11360@pengutronix.de> (raw)
In-Reply-To: <20140318013507.GD30471@atomide.com>
[-- Attachment #1: Type: text/plain, Size: 2059 bytes --]
Hi,
On Mon, Mar 17, 2014 at 06:35:07PM -0700, Tony Lindgren wrote:
> * Russell King - ARM Linux <linux@arm.linux.org.uk> [140317 16:35]:
> > There's been a couple of regressions on OMAP4430 SDP I've only recently
> > noticed:
> >
> > http://www.arm.linux.org.uk/developer/build/result.php?type=boot&idx=1597
> >
> > Configuring network interfaces... udhcpc (v1.9.1) started
> > Sending discover...
> > Sending discover...
> > Sending discover...
> > No lease, failing
> > done.
> >
> > No link lights come up either. The hardware is fine because uboot manages
> > to successfully tftp the kernel.
> >
> > It looks like it was working in -rc4+armsoc and -rc5+armsoc, but not
> > -rc6+armsoc.
> >
> > From what I can see, nothing has changed in drivers/net/ethernet/micrel/
> > since rc5.
> >
> > I've been through the delta from 3.14-rc5, and I don't see anything
> > obvious. Any ideas? Known problem?
>
> Seems like plain v3.14-rc6 fails for me while -rc5 works. Bisecting
> points to:
>
> 66fda75f regulator: core: Replace direct ops->disable usage
>
> Also verified that v3.14-rc6 with 66fda75f reverted also works.
>
> Markus & Mark, any ideas?
I just had a look into the specific dts 'omap4-sdp.dts'. It defines a
'vdd_eth' at the top of the file, which is a fixed regulator using gpios
with 'regulator-boot-on'. This regulator is also passed to the ks8851
driver as vdd-supply. But this supply is not used in the driver.
The problem may be that the fixed regulator was never enabled/disabled
before my patch. As the network driver does not enable the regulator
manually, it will be disabled by the regulator framework. A
'regulator-always-on' may help here.
Regards,
Markus
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2014-03-18 7:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-17 23:32 OMAP4 SDP regression Russell King - ARM Linux
2014-03-18 1:35 ` Tony Lindgren
2014-03-18 7:59 ` Markus Pargmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140318075935.GG11360@pengutronix.de \
--to=mpa@pengutronix.de \
--cc=broonie@linaro.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.