From: Stephen Hemminger <stephen@networkplumber.org>
To: David L Stevens <dlstevens@us.ibm.com>
Cc: David Miller <davem@davemloft.net>,
Stephen Hemminger <shemminger@vyatta.com>,
Cong Wang <amwang@redhat.com>,
netdev@vger.kernel.org
Subject: Re: [PATCHv2 net-next] VXLAN: fix nonfunctional neigh_reduce
Date: Tue, 18 Mar 2014 08:47:40 -0700 [thread overview]
Message-ID: <20140318084740.729e21a6@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <201403181521.s2IFL99N027716@lab1.dls>
On Tue, 18 Mar 2014 11:21:09 -0400
David L Stevens <dlstevens@us.ibm.com> wrote:
> + struct sk_buff *reply = NULL;
> + struct nd_msg *ns, *na;
> + struct ipv6hdr *pip6 = ipv6_hdr(reply);
Redundant initialization of reply and pip6.
Doing ipv6_hdr(NULL) is bogus.
prev parent reply other threads:[~2014-03-18 15:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-18 15:21 [PATCHv2 net-next] VXLAN: fix nonfunctional neigh_reduce David L Stevens
2014-03-18 15:40 ` Daniel Baluta
2014-03-18 15:46 ` Stephen Hemminger
2014-03-18 15:47 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140318084740.729e21a6@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber.org \
--cc=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=dlstevens@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.