From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Takashi Iwai <tiwai-l3A5Bk7waGM@public.gmane.org>
Cc: Lars-Peter Clausen <lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>,
Dylan Reid <dgreid-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
abrestic-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org
Subject: Re: [PATCH] regmap: Fix possible sleep-in-atomic in fast io mode
Date: Tue, 18 Mar 2014 11:27:56 +0000 [thread overview]
Message-ID: <20140318112756.GM11706@sirena.org.uk> (raw)
In-Reply-To: <1395141600-24558-1-git-send-email-tiwai-l3A5Bk7waGM@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 536 bytes --]
On Tue, Mar 18, 2014 at 12:20:00PM +0100, Takashi Iwai wrote:
> regmap deploys the spinlock for the protection when set up in fast_io
> mode. But some places are still left with possible sleep in the lock,
> typically allocating memory with GFP_KERNEL. This patch fixes these
> calls by moving the allocations out of the lock.
You should have split these two unrelated changes into two patches. I
already have a fix for the cache sync in my tree locally which I will
test just a soon as I fix whatever broke the -next build for me.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-03-18 11:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-18 11:20 [PATCH] regmap: Fix possible sleep-in-atomic in fast io mode Takashi Iwai
[not found] ` <1395141600-24558-1-git-send-email-tiwai-l3A5Bk7waGM@public.gmane.org>
2014-03-18 11:27 ` Mark Brown [this message]
[not found] ` <20140318112756.GM11706-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-03-18 11:38 ` Takashi Iwai
[not found] ` <s5hvbvbrb25.wl%tiwai-l3A5Bk7waGM@public.gmane.org>
2014-03-18 11:42 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140318112756.GM11706@sirena.org.uk \
--to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=abrestic-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
--cc=dgreid-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=tiwai-l3A5Bk7waGM@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.