From: Mark Brown <broonie@kernel.org>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: alsa-devel@alsa-project.org, Lars-Peter Clausen <lars@metafoo.de>,
nsekhar@ti.com, Liam Girdwood <lgirdwood@gmail.com>,
Jyri Sarha <jsarha@ti.com>,
zonque@gmail.com
Subject: Re: [PATCH v2 3/4] ASoC: davinci-mcasp: Constraint on the period and buffer size based on FIFO usage
Date: Tue, 18 Mar 2014 12:42:43 +0000 [thread overview]
Message-ID: <20140318124243.GV11706@sirena.org.uk> (raw)
In-Reply-To: <53283DA4.2080609@ti.com>
[-- Attachment #1.1: Type: text/plain, Size: 814 bytes --]
On Tue, Mar 18, 2014 at 02:35:48PM +0200, Peter Ujfalusi wrote:
> On 03/17/2014 06:52 PM, Mark Brown wrote:
> > It's sounding like if we should be doing it this is a general
> > thing which we should be constraining presumably it'd apply to all
> > drivers, not just this one, and so shouldn't be being fixed in the
> > driver but it's not obvious to me why the period constraint isn't
> > sufficient.
> It can only be done if we have fixed FIFO for the dai. Right now this is kind
> of true for McASP. In HW we actually have 64 32bit word FIFO and currently you
> can set the desired FIFO depth via DT/pdata. I'm not really happy about this
Sorry, what I meant was more the bit where you were setting the
constraint on both the buffer and the period than the constraint itself
- that seemed somehow redundant.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2014-03-18 12:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-14 14:42 [PATCH v2 0/4] ASoC: davinci: edma dmaengine PCM and mcasp preparation Peter Ujfalusi
2014-03-14 14:42 ` [PATCH v2 1/4] ASoC: davinci: Add edma dmaengine platform driver Peter Ujfalusi
2014-03-16 10:54 ` Lars-Peter Clausen
2014-03-17 16:20 ` Mark Brown
2014-03-14 14:42 ` [PATCH v2 2/4] ASoC: davinci-mcasp: Provide correct filter_data for dmaengine for non-DT boot Peter Ujfalusi
2014-03-17 16:21 ` Mark Brown
2014-03-14 14:42 ` [PATCH v2 3/4] ASoC: davinci-mcasp: Constraint on the period and buffer size based on FIFO usage Peter Ujfalusi
2014-03-16 11:18 ` Lars-Peter Clausen
2014-03-17 13:28 ` Peter Ujfalusi
2014-03-17 16:52 ` Mark Brown
2014-03-18 12:35 ` Peter Ujfalusi
2014-03-18 12:42 ` Mark Brown [this message]
2014-03-14 14:42 ` [PATCH v2 4/4] ASoC: davinci-mcasp: Assign the dma_data earlier in dai_probe callback Peter Ujfalusi
2014-03-17 16:44 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140318124243.GV11706@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=jsarha@ti.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=nsekhar@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.