All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: linux-scsi@vger.kernel.org
Subject: BLIST_SINGLELUN
Date: Tue, 18 Mar 2014 07:28:04 -0700	[thread overview]
Message-ID: <20140318142804.GA25309@infradead.org> (raw)

Does anyone still have a device listed in the blacklist with
BLIST_SINGLELUN?

>From reading the source code I'm not sure the code actually works as
expected currently, or did for a long time.

While scsi_target_queue_ready makes sure to only queue commands to the
right lun as long as starget_sdev_user is set, scsi_single_lun_run
clears starget_sdev_user as soon as the any command completes on a
target marked with the flag, allowing the following situation:

 - cmd 1 lun 0		submitted
 - cmd 2 lun 0		submitted
 - cmd 1 lun 0		completed
 - cmd 9 lun 1		submitted

and thus having commands for two luns in flight at the same time
if we hit the narrow enough race of entering the scsi_request_fn
for lun 1 before scsi_single_lun_run does so for lun 0.

             reply	other threads:[~2014-03-18 14:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-18 14:28 Christoph Hellwig [this message]
2014-03-19 15:42 ` BLIST_SINGLELUN Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140318142804.GA25309@infradead.org \
    --to=hch@infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.