From: mporter@linaro.org (Matt Porter)
To: linux-arm-kernel@lists.infradead.org
Subject: [V2] arm: pj4: check cpu id for pj4 cp0 access
Date: Tue, 18 Mar 2014 16:15:37 -0400 [thread overview]
Message-ID: <20140318201537.GA20942@beef> (raw)
In-Reply-To: <1371200637-20850-1-git-send-email-chao.xie@marvell.com>
On Fri, Jun 14, 2013 at 05:03:57AM -0400, Chao Xie wrote:
> Check cpu id in pj4_cp0_init. So for no-PJ4 V7 cpus,
> pj4_cpu0_init just return.
> This fix will help to make the all the V7 cpus(pj4 and no-PJ4)
> use same platform code.
>
> Signed-off-by: Chao Xie <chao.xie@marvell.com>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
This patch fixes a boot failure in next now that ARCH_DOVE (and thus
CPU_PJ4) are enabled in multi_v7_defconfig. I verified that boot works
again in next with the BCM28155-AP board.
Tested-by: Matt Porter <mporter@linaro.org>
> arch/arm/kernel/pj4-cp0.c | 11 +++++++++++
> 1 files changed, 11 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/kernel/pj4-cp0.c b/arch/arm/kernel/pj4-cp0.c
> index 679cf4d..bf658d3 100644
> --- a/arch/arm/kernel/pj4-cp0.c
> +++ b/arch/arm/kernel/pj4-cp0.c
> @@ -17,6 +17,10 @@
> #include <linux/init.h>
> #include <linux/io.h>
> #include <asm/thread_notify.h>
> +#include <asm/cputype.h>
> +
> +#define CORE_PJ4_MASK 0xfffffff0
> +#define CORE_PJ4_ID 0x562f5840
>
> static int iwmmxt_do(struct notifier_block *self, unsigned long cmd, void *t)
> {
> @@ -79,6 +83,13 @@ static void __init pj4_cp_access_write(u32 value)
> static int __init pj4_cp0_init(void)
> {
> u32 cp_access;
> + unsigned int cpuid;
> +
> + cpuid = read_cpuid_id();
> +
> + /* If it is not a pj4 core, skip it. */
> + if ((cpuid & CORE_PJ4_MASK) != CORE_PJ4_ID)
> + return 0;
>
> cp_access = pj4_cp_access_read() & ~0xf;
> pj4_cp_access_write(cp_access);
next prev parent reply other threads:[~2014-03-18 20:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-14 9:03 [PATCH V2] arm: pj4: check cpu id for pj4 cp0 access Chao Xie
2013-06-14 14:30 ` Arnd Bergmann
2014-03-18 20:15 ` Matt Porter [this message]
2014-03-18 20:19 ` [V2] " Kevin Hilman
2014-03-18 20:32 ` Russell King - ARM Linux
2014-03-19 1:36 ` Chao Xie
2014-03-20 19:04 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140318201537.GA20942@beef \
--to=mporter@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.