From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758628AbaCRX3l (ORCPT ); Tue, 18 Mar 2014 19:29:41 -0400 Received: from e37.co.us.ibm.com ([32.97.110.158]:38560 "EHLO e37.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757451AbaCRX3k (ORCPT ); Tue, 18 Mar 2014 19:29:40 -0400 Date: Tue, 18 Mar 2014 16:29:35 -0700 From: "Paul E. McKenney" To: Monam Agarwal Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, eddie.wai@broadcom.com Subject: Re: [PATCH 3/9] rcu: Replace rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL) in drivers/net/macvtap.c Message-ID: <20140318232935.GC4420@linux.vnet.ibm.com> Reply-To: paulmck@linux.vnet.ibm.com References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14031823-7164-0000-0000-00000069BFDB Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 19, 2014 at 04:14:31AM +0530, Monam Agarwal wrote: > Signed-off-by: Monam Agarwal Reviewed-by: Paul E. McKenney > --- > drivers/net/macvtap.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c > index 1b7082d..7c88d13 100644 > --- a/drivers/net/macvtap.c > +++ b/drivers/net/macvtap.c > @@ -145,8 +145,8 @@ static void macvtap_put_queue(struct macvtap_queue *q) > if (vlan) { > int index = get_slot(vlan, q); > > - rcu_assign_pointer(vlan->taps[index], NULL); > - rcu_assign_pointer(q->vlan, NULL); > + RCU_INIT_POINTER(vlan->taps[index], NULL); > + RCU_INIT_POINTER(q->vlan, NULL); > sock_put(&q->sk); > --vlan->numvtaps; > } > @@ -223,8 +223,8 @@ static void macvtap_del_queues(struct net_device *dev) > lockdep_is_held(&macvtap_lock)); > if (q) { > qlist[j++] = q; > - rcu_assign_pointer(vlan->taps[i], NULL); > - rcu_assign_pointer(q->vlan, NULL); > + RCU_INIT_POINTER(vlan->taps[i], NULL); > + RCU_INIT_POINTER(q->vlan, NULL); > vlan->numvtaps--; > } > } > -- > 1.7.9.5 >