From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] eigen: (optionally) install unsupported modules
Date: Tue, 18 Mar 2014 23:55:42 +0100 [thread overview]
Message-ID: <20140318235542.2eb029b1@skate> (raw)
In-Reply-To: <1395173894-4811-2-git-send-email-zinosat@tiscali.it>
Dear Davide Viti,
On Tue, 18 Mar 2014 21:18:14 +0100, Davide Viti wrote:
> From: Davide Viti <d.viti@infosolution.it>
>
>
> Signed-off-by: Davide Viti <zinosat@tiscali.it>
We probably want the title of the patch to be:
eigen: add an option to install unsupported modules
>
> +if BR2_PACKAGE_EIGEN
> +
> +config BR2_PACKAGE_EIGEN_UNSUPPORTED_MODULES
> + bool "unsupported modules"
Indentation is wrong here: there should be one tab before the "bool"
statement.
> + help
> + Install eigen unsupported modules
> +endif
> +
> comment "eigen needs a toolchain w/ C++"
> depends on !BR2_INSTALL_LIBSTDCPP
> diff --git a/package/eigen/eigen.mk b/package/eigen/eigen.mk
> index 5abd464..388dd63 100644
> --- a/package/eigen/eigen.mk
> +++ b/package/eigen/eigen.mk
> @@ -13,6 +13,14 @@ EIGEN_LICENSE_FILES = COPYING.MPL2 COPYING.BSD COPYING.LGPL COPYING.README
> EIGEN_INSTALL_STAGING = YES
> EIGEN_INSTALL_TARGET = NO
>
> +define EIGEN_INSTALL_UNSUPPORTED_MODULES
> + cp -a $(@D)/unsupported $(STAGING_DIR)/usr/include/
I'm a bit worried about having a directory called
$(STAGING_DIR)/usr/include/unsupported. Shouldn't this directory be
installed *below* the $(STAGING_DIR)/usr/include/Eigen directory
created by the normal installation of Eigen?
> +endef
> +
> +ifeq ($(BR2_PACKAGE_EIGEN_UNSUPPORTED_MODULES),y)
> + EIGEN_POST_INSTALL_STAGING_HOOKS += EIGEN_INSTALL_UNSUPPORTED_MODULES
> +endif
I believe we normally don't really use post install hooks when there is
a definition of the staging install commands. Instead, we use the
following idiom:
ifeq ($(BR2_PACKAGE_EIGEN_UNSUPPORTED_MODULES),y)
define EIGEN_INSTALL_UNSUPPORTED_MODULES_CMDS
cp -a ...
endef
endif
define EIGEN_INSTALL_STAGING_CMDS
... existing installation steps ...
$(EIGEN_INSTALL_UNSUPPORTED_MODULES_CMDS)
endef
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-03-18 22:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-18 20:18 [Buildroot] [v2] eigen: (optionally) install unsupported modules Davide Viti
2014-03-18 20:18 ` [Buildroot] [PATCH] " Davide Viti
2014-03-18 22:55 ` Thomas Petazzoni [this message]
2014-03-19 7:25 ` Samuel Martin
2014-03-19 8:07 ` Davide Viti
2014-03-19 17:11 ` Thomas Petazzoni
2014-03-18 22:52 ` [Buildroot] [v2] " Thomas Petazzoni
-- strict thread matches above, loose matches on Subject: below --
2014-03-18 15:48 [Buildroot] [PATCH] " Davide Viti
2014-03-18 15:48 ` Davide Viti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140318235542.2eb029b1@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.