From: "Linus Lüssing" <linus.luessing@web.de>
To: Antonio Quartulli <antonio@meshcoding.com>
Cc: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCHv2 next 02/11] batman-adv: don't mess up with the netdev refcounting if not needed
Date: Wed, 19 Mar 2014 11:02:07 +0100 [thread overview]
Message-ID: <20140319100207.GJ5208@Linus-Debian> (raw)
In-Reply-To: <1395216532-31099-2-git-send-email-antonio@meshcoding.com>
On Wed, Mar 19, 2014 at 09:08:43AM +0100, Antonio Quartulli wrote:
> Looking for an interface and increasing its refcounter only
> to check if it really exists is not really useful and makes
> the code look more complex without a real gain.
Hm, I was intending to use it somewhere else as well with the
next series of patches. See:
http://git.open-mesh.org/batman-adv.git/commitdiff/bd774bd7e00bbe062cb0ab591d50be77e30a557a?hp=c9c3d53851f832b32188c9dd9a3dace96a33a0c3
But ok, since it is not in a yet scheduled patchset, I guess
you're right, then it should better be introduced when it is
needed.
On another note, I think you're introducing a bug/memoryleak
here for the compat-code case for
netdev_master_upper_dev_get_rcu().
Cheers, Linus
next prev parent reply other threads:[~2014-03-19 10:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-19 8:08 [B.A.T.M.A.N.] [PATCHv2 next 01/11] batman-adv: remove useless goto Antonio Quartulli
2014-03-19 8:08 ` [B.A.T.M.A.N.] [PATCHv2 next 02/11] batman-adv: don't mess up with the netdev refcounting if not needed Antonio Quartulli
2014-03-19 10:02 ` Linus Lüssing [this message]
2014-03-19 8:08 ` [B.A.T.M.A.N.] [PATCHv2 next 03/11] batman-adv: fix multicast kerneldoc Antonio Quartulli
2014-03-19 9:03 ` Linus Lüssing
2014-03-19 9:12 ` Antonio Quartulli
2014-03-19 9:38 ` Linus Lüssing
2014-03-19 8:08 ` [B.A.T.M.A.N.] [PATCHv2 next 04/11] " Antonio Quartulli
2014-03-19 8:08 ` [B.A.T.M.A.N.] [PATCHv2 next 05/11] " Antonio Quartulli
2014-03-19 8:08 ` [B.A.T.M.A.N.] [PATCHv2 next 06/11] " Antonio Quartulli
2014-03-19 8:08 ` [B.A.T.M.A.N.] [PATCHv2 next 07/11] " Antonio Quartulli
2014-03-19 8:08 ` [B.A.T.M.A.N.] [PATCHv2 next 08/11] batman-adv: adjust copyright disclaimer in multicast files Antonio Quartulli
2014-03-19 8:08 ` [B.A.T.M.A.N.] [PATCHv2 next 09/11] batman-adv: fix code style Antonio Quartulli
2014-03-19 8:08 ` [B.A.T.M.A.N.] [PATCHv2 next 10/11] batman-adv: fix more " Antonio Quartulli
2014-03-19 8:08 ` [B.A.T.M.A.N.] [PATCHv2 next 11/11] " Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140319100207.GJ5208@Linus-Debian \
--to=linus.luessing@web.de \
--cc=antonio@meshcoding.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.