All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: "Yan, Zheng" <zheng.z.yan@intel.com>,
	linux-kernel@vger.kernel.org, acme@infradead.org,
	eranian@google.com, andi@firstfloor.org
Subject: Re: [PATCH 4/4] perf/x86/uncore: modularize Intel uncore driver
Date: Wed, 19 Mar 2014 13:55:55 +0100	[thread overview]
Message-ID: <20140319125555.GA19317@gmail.com> (raw)
In-Reply-To: <20140319124431.GN27632@laptop.programming.kicks-ass.net>


* Peter Zijlstra <peterz@infradead.org> wrote:

> On Wed, Mar 19, 2014 at 12:53:23PM +0100, Ingo Molnar wrote:
> > >
> > > Ah; but do you want this config option hidden in the "Processor 
> > > type and features" menu or would they be better in "General 
> > > setup/Kernel Performance Events and Counters" ?
> > 
> > What's your preference? There's a vali argument for both: the 
> > uncore driver is part of the CPU, but it's also a perf driver.
> 
> My initial thought was having it in the perf menu because that's 
> relatively easy to find and not big and cluttered (yet) like the 
> arch menu is.
> 
> I actually had to double check I had the right patches applied 
> because I couldn't find it the first time.

Okay, agreed, lets do it that way. It's also the better choice UI 
wise: arguably people will associate this driver with 'perf', not with 
CPU features.

Thanks,

	Ingo

  reply	other threads:[~2014-03-19 12:56 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-18  8:56 [PATCH 1/4] perf: allow building PMU driver as module Yan, Zheng
2014-03-18  8:56 ` [PATCH 2/4] hrtimer: export __hrtimer_start_range_ns Yan, Zheng
2014-03-19  8:47   ` Peter Zijlstra
2014-03-19  9:53     ` Thomas Gleixner
2014-03-19  9:58       ` Peter Zijlstra
2014-04-18 13:08   ` [tip:perf/core] hrtimer: Export __hrtimer_start_range_ns() tip-bot for Yan, Zheng
2014-03-18  8:56 ` [PATCH 3/4] perf/x86: export perf_assign_events Yan, Zheng
2014-04-18 13:08   ` [tip:perf/core] perf/x86: Export perf_assign_events() tip-bot for Yan, Zheng
2014-03-18  8:56 ` [PATCH 4/4] perf/x86/uncore: modularize Intel uncore driver Yan, Zheng
2014-03-19  8:49   ` Peter Zijlstra
2014-03-19 11:32     ` Ingo Molnar
2014-03-19 11:42       ` Peter Zijlstra
2014-03-19 11:53         ` Ingo Molnar
2014-03-19 12:44           ` Peter Zijlstra
2014-03-19 12:55             ` Ingo Molnar [this message]
2014-03-20 15:01   ` Vince Weaver
2014-03-20 15:50     ` Andi Kleen
2014-04-18 13:08 ` [tip:perf/core] perf: Allow building PMU drivers as modules tip-bot for Yan, Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140319125555.GA19317@gmail.com \
    --to=mingo@kernel.org \
    --cc=acme@infradead.org \
    --cc=andi@firstfloor.org \
    --cc=eranian@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=zheng.z.yan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.