From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Richard Weinberger <richard@nod.at>
Cc: linux-mtd@lists.infradead.org, computersforpeace@gmail.com,
dwmw2@infradead.org, linux-kernel@vger.kernel.org,
dedekind1@gmail.com
Subject: Re: [PATCH 2/2] UBI: block: Implement kernel_param_ops->get()
Date: Wed, 19 Mar 2014 10:15:43 -0300 [thread overview]
Message-ID: <20140319131543.GA529@arch.cereza> (raw)
In-Reply-To: <1395225803-25037-2-git-send-email-richard@nod.at>
Hi Richard,
On Mar 19, Richard Weinberger wrote:
> The ->get() function is not optional.
>
[..]
> static struct kernel_param_ops ubiblock_param_ops = {
> .set = ubiblock_set_param,
> + .get = param_get_charp,
> };
> module_param_cb(block, &ubiblock_param_ops, NULL, 0);
The comment for the function says they are both optional:
/**
* module_param_cb - general callback for a module/cmdline parameter
* @name: a valid C identifier which is the parameter name.
* @ops: the set & get operations for this parameter.
* @perm: visibility in sysfs.
*
* The ops can have NULL set or get functions.
*/
This has no visibility in sysfs, so I can't see how having a NULL
get() is a problem. What's the issue you're trying to fix here?
Maybe I'm missing something?
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Richard Weinberger <richard@nod.at>
Cc: dedekind1@gmail.com, dwmw2@infradead.org,
computersforpeace@gmail.com, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] UBI: block: Implement kernel_param_ops->get()
Date: Wed, 19 Mar 2014 10:15:43 -0300 [thread overview]
Message-ID: <20140319131543.GA529@arch.cereza> (raw)
In-Reply-To: <1395225803-25037-2-git-send-email-richard@nod.at>
Hi Richard,
On Mar 19, Richard Weinberger wrote:
> The ->get() function is not optional.
>
[..]
> static struct kernel_param_ops ubiblock_param_ops = {
> .set = ubiblock_set_param,
> + .get = param_get_charp,
> };
> module_param_cb(block, &ubiblock_param_ops, NULL, 0);
The comment for the function says they are both optional:
/**
* module_param_cb - general callback for a module/cmdline parameter
* @name: a valid C identifier which is the parameter name.
* @ops: the set & get operations for this parameter.
* @perm: visibility in sysfs.
*
* The ops can have NULL set or get functions.
*/
This has no visibility in sysfs, so I can't see how having a NULL
get() is a problem. What's the issue you're trying to fix here?
Maybe I'm missing something?
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-03-19 13:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-19 10:43 [PATCH 1/2] UBI: block: Remove __initdata from ubiblock_param_ops Richard Weinberger
2014-03-19 10:43 ` Richard Weinberger
2014-03-19 10:43 ` [PATCH 2/2] UBI: block: Implement kernel_param_ops->get() Richard Weinberger
2014-03-19 10:43 ` Richard Weinberger
2014-03-19 13:15 ` Ezequiel Garcia [this message]
2014-03-19 13:15 ` Ezequiel Garcia
2014-03-19 13:23 ` Richard Weinberger
2014-03-19 13:23 ` Richard Weinberger
2014-03-19 13:26 ` Richard Weinberger
2014-03-19 13:26 ` Richard Weinberger
2014-03-19 13:24 ` [PATCH 1/2] UBI: block: Remove __initdata from ubiblock_param_ops Ezequiel Garcia
2014-03-19 13:24 ` Ezequiel Garcia
2014-03-21 17:39 ` Artem Bityutskiy
2014-03-21 17:39 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140319131543.GA529@arch.cereza \
--to=ezequiel.garcia@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.