From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] mfd: twl-core: Fix accessibility of some twl4030 audio registers Date: Wed, 19 Mar 2014 08:31:41 -0700 Message-ID: <20140319153140.GB12934@atomide.com> References: <20140310191250.34f1410e@tomas.local.tbs-biometrics.cz> <531EC981.8090806@ti.com> <20140318172650.GA307@atomide.com> <20140318201947.GT25478@lee--X1> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-03-ewr.mailhop.org ([204.13.248.66]:22404 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S965001AbaCSPbs (ORCPT ); Wed, 19 Mar 2014 11:31:48 -0400 Content-Disposition: inline In-Reply-To: <20140318201947.GT25478@lee--X1> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Lee Jones Cc: Peter Ujfalusi , Tomas Novotny , linux-omap@vger.kernel.org * Lee Jones [140318 13:23]: > > > > There are some unused registers in twl4030 at I2C address 0x49 and function > > > > twl4030_49_nop_reg() is used to check accessibility of that registers. These > > > > registers are written in decimal format but the values are correct in > > > > hexadecimal format. (It can be checked few lines above the patched code - > > > > these registers are marked as unused there.) > > > > > > > > As a consequence three registers of audio submodule are treated as > > > > inaccessible (preamplifier carkit right and both handsfree registers). > > > > > > > > CC: Peter Ujfalusi > > > > Signed-off-by: Tomas Novotny > > > > --- > > > > drivers/mfd/twl-core.c | 10 +++++----- > > > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > > > > > diff --git a/drivers/mfd/twl-core.c b/drivers/mfd/twl-core.c > > > > index ed71832..e87140b 100644 > > > > --- a/drivers/mfd/twl-core.c > > > > +++ b/drivers/mfd/twl-core.c > > > > @@ -282,11 +282,11 @@ static struct reg_default twl4030_49_defaults[] = { > > > > static bool twl4030_49_nop_reg(struct device *dev, unsigned int reg) > > > > { > > > > switch (reg) { > > > > - case 0: > > > > - case 3: > > > > - case 40: > > > > - case 41: > > > > - case 42: > > > > + case 0x00: > > > > + case 0x03: > > > > + case 0x40: > > > > + case 0x41: > > > > + case 0x42: > > > > > > Uhm, I can not be that @#$%^& that I did this... I have no idea how I left out > > > the "0x" > > > > > > Thanks for spotting it! > > > > > > Acked-by Peter Ujfalusi > > > > Peter, if this does not make it to the -rc series, care to send this to > > the stable for inclusion after it hits mainline? > > > > This fixes twl4030 audio regression at least on boards using HandsfreeL > > for audio. > > I think it's a little late in the cycle to send this to the -rcs. > > Stable will be Cc'ed however. That's fine with me thanks. Tony