From mboxrd@z Thu Jan  1 00:00:00 1970
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [PATCH] serial: Expand the PCIe params for an
 Oxford two port serial cards.
Date: Wed, 19 Mar 2014 11:54:56 -0400
Message-ID: <20140319155456.GA17488@phenom.dumpdata.com>
References: <1395242327-10544-1-git-send-email-konrad.wilk@oracle.com>
	<5329C5EB0200007800125CFB@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <5329C5EB0200007800125CFB@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Konrad Rzeszutek Wilk <konrad@kernel.org>, keir@xen.org, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Wed, Mar 19, 2014 at 03:29:31PM +0000, Jan Beulich wrote:
> >>> On 19.03.14 at 16:18, Konrad Rzeszutek Wilk <konrad@kernel.org> wrote:
> > @@ -161,12 +172,24 @@ static const struct ns16550_config_mmio __initconst uart_config[] =
> >      /* OXPCIe952 1 Native UART  */
> >      {
> >          .vendor_id = PCI_VENDOR_ID_OXSEMI,
> > +        .dev_id = 0xc158,
> > +        .param = param_oxford_2port,
> > +    },
> > +    /* OXPCIe952 1 Native UART  */
> > +    {
> > +        .vendor_id = PCI_VENDOR_ID_OXSEMI,
> >          .dev_id = 0xc13d,
> >          .param = param_oxford,
> >      },
> >      /* OXPCIe952 1 Native UART  */
> >      {
> >          .vendor_id = PCI_VENDOR_ID_OXSEMI,
> > +        .dev_id = 0xc15d,
> > +        .param = param_oxford_2port,
> > +    },
> > +    /* OXPCIe952 1 Native UART  */
> > +    {
> > +        .vendor_id = PCI_VENDOR_ID_OXSEMI,
> >          .dev_id = 0xc40b,
> >          .param = param_oxford,
> >      },
> 
> While at first I only wanted to ask by what principle these entries
> are being ordered, I now additionally wonder what really

I was putting them in the order of device_id. But I can also
put them at the end of the structure if you would prefer?

> distinguishes them (beyond the device ID): They all have the same
> name, and even the newly added ones say "1 native UART",

Argh. Copy-n-paste error. Should have said 'OXPCIe952 2 Native UART'


> despite the patch subject saying "two port".
> 
> Jan
>