All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 2/2] eigen: add an option to install unsupported modules
Date: Wed, 19 Mar 2014 19:01:26 +0100	[thread overview]
Message-ID: <20140319190126.7d7f6358@skate> (raw)
In-Reply-To: <1395244134-32329-2-git-send-email-d.viti@infosolution.it>

Dear Davide Viti,

On Wed, 19 Mar 2014 16:48:54 +0100, Davide Viti wrote:

> +config BR2_PACKAGE_EIGEN_UNSUPPORTED_MODULES
> +       bool "unsupported modules"
> +       help

Indentation should be done with one tab, not spaces.

> +         Install eigen unsupported modules

Indentation should be one tab + two spaces.



> +endif
> +
>  comment "eigen needs a toolchain w/ C++"
>  	depends on !BR2_INSTALL_LIBSTDCPP
> diff --git a/package/eigen/eigen.mk b/package/eigen/eigen.mk
> index 9a5ce7d..ac030a9 100644
> --- a/package/eigen/eigen.mk
> +++ b/package/eigen/eigen.mk
> @@ -14,12 +14,19 @@ EIGEN_INSTALL_STAGING = YES
>  EIGEN_INSTALL_TARGET = NO
>  EIGEN_DEST_DIR = $(STAGING_DIR)/usr/include/eigen3
>  
> +ifeq ($(BR2_PACKAGE_EIGEN_UNSUPPORTED_MODULES),y)
> +define EIGEN_INSTALL_UNSUPPORTED_MODULES_CMDS
> +	cp -a $(@D)/unsupported $(EIGEN_DEST_DIR)
> +endef
> +endif
> +
>  # This package only consists of headers that need to be
>  # copied over to the sysroot for compile time use
>  define EIGEN_INSTALL_STAGING_CMDS
>  	$(RM) -r $(EIGEN_DEST_DIR)
>  	mkdir -p $(EIGEN_DEST_DIR)
>  	cp -a $(@D)/Eigen $(EIGEN_DEST_DIR)
> +	$(EIGEN_INSTALL_UNSUPPORTED_MODULES_CMDS)

Here the indentation is correct, it's done with one tab.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2014-03-19 18:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-19 15:48 [Buildroot] [PATCH v4 1/2] eigen: follow default installation scheme Davide Viti
2014-03-19 15:48 ` [Buildroot] [PATCH v4 2/2] eigen: add an option to install unsupported modules Davide Viti
2014-03-19 18:01   ` Thomas Petazzoni [this message]
2014-03-19 18:00 ` [Buildroot] [PATCH v4 1/2] eigen: follow default installation scheme Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140319190126.7d7f6358@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.