All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Mathieu Maret <mathieu.maret@gmail.com>
Cc: pe1dnn@amsat.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2 4/5] staging: wlags49_h2: Correct macro style in wl_netdev.c
Date: Thu, 20 Mar 2014 01:53:02 +0000	[thread overview]
Message-ID: <20140320015302.GA21123@kroah.com> (raw)
In-Reply-To: <1395269774-31576-1-git-send-email-mathieu.maret@gmail.com>

On Wed, Mar 19, 2014 at 11:56:14PM +0100, Mathieu Maret wrote:
> Multi statement macro should use do{}while(0)
> 
> patch v2 does not break compilation
> ---
>  drivers/staging/wlags49_h2/wl_netdev.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/wlags49_h2/wl_netdev.c b/drivers/staging/wlags49_h2/wl_netdev.c
> index 255d291..0e553ae 100644
> --- a/drivers/staging/wlags49_h2/wl_netdev.c
> +++ b/drivers/staging/wlags49_h2/wl_netdev.c
> @@ -107,9 +107,11 @@
>   * macros
>   ******************************************************************************/
>  #define BLOCK_INPUT(buf, len) \
> -    desc->buf_addr = buf; \
> -    desc->BUF_SIZE = len; \
> -    status = hcf_rcv_msg(&(lp->hcfCtx), desc, 0)
> +	do { \
> +		desc->buf_addr = buf; \
> +		desc->BUF_SIZE = len; \
> +		status = hcf_rcv_msg(&(lp->hcfCtx), desc, 0); \
> +	} while (0)

This patch is already in my tree :(

thanks,

greg k-h

      reply	other threads:[~2014-03-20  1:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-19 22:56 [PATCHv2 4/5] staging: wlags49_h2: Correct macro style in wl_netdev.c Mathieu Maret
2014-03-20  1:53 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140320015302.GA21123@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.maret@gmail.com \
    --cc=pe1dnn@amsat.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.