From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Graf Subject: Re: [PATCH net 2/3] ipmr: fix mfc notification flags Date: Thu, 20 Mar 2014 07:39:11 +0000 Message-ID: <20140320073911.GD16640@casper.infradead.org> References: <1395247671-9356-1-git-send-email-nicolas.dichtel@6wind.com> <1395247671-9356-2-git-send-email-nicolas.dichtel@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: davem@davemloft.net, netdev@vger.kernel.org To: Nicolas Dichtel Return-path: Received: from casper.infradead.org ([85.118.1.10]:56487 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751779AbaCTHjM (ORCPT ); Thu, 20 Mar 2014 03:39:12 -0400 Content-Disposition: inline In-Reply-To: <1395247671-9356-2-git-send-email-nicolas.dichtel@6wind.com> Sender: netdev-owner@vger.kernel.org List-ID: On 03/19/14 at 05:47pm, Nicolas Dichtel wrote: > Commit 8cd3ac9f9b7b ("ipmr: advertise new mfc entries via rtnl") reuses the > function ipmr_fill_mroute() to notify mfc events. > But this function was used only for dump and thus was always setting the > flag NLM_F_MULTI, which is wrong in case of a single notification. > > Libraries like libnl will wait forever for NLMSG_DONE. > > CC: Thomas Graf > Signed-off-by: Nicolas Dichtel LGTM Acked-by: Thomas Graf