Re: [Qemu-devel] [PATCH v2 0/2] Stop reinit of XBZRLE.lock

["Dr. David Alan Gilbert" <dgilbert@redhat.com>]

* Markus Armbruster (armbru@redhat.com) wrote:
> "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com> writes:
> 
> > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> >
> > Markus Armbruster spotted that the XBZRLE.lock might get initalised
> > multiple times in the case of a second attempted migration, and
> > that's undefined behaviour for pthread_mutex_init.
> >
> > This patchset is based on Markus' proto-patch in the discussions
> > off v1.
> >
> > --
> > v2
> >    Rework completely based on Markus's patch
> >
> > Dr. David Alan Gilbert (2):
> >   Provide init function for ram migration
> >   Init the XBZRLE.lock in ram_mig_init
> 
> Second patch does a fair but more than its subject suggests.  Perhaps
> "XBZRLE: Rework locking to fix double initialization" would be better.
> Still doesn't cover the upgrade from debugging prints to proper error
> reporting.  Maybe that should be a separate patch.  Up to you.

I added the error reporting ones, because I ended up respinning my last
patch after Paolo asked for them.

Dave

> 
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK