From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 06/12] drm/i915: remove rps local variables Date: Thu, 20 Mar 2014 14:46:54 +0100 Message-ID: <20140320134654.GM30571@phenom.ffwll.local> References: <1392692512-2268-1-git-send-email-benjamin.widawsky@intel.com> <1395279079-12704-1-git-send-email-benjamin.widawsky@intel.com> <1395279079-12704-7-git-send-email-benjamin.widawsky@intel.com> <20140320073052.GI4890@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f45.google.com (mail-ee0-f45.google.com [74.125.83.45]) by gabe.freedesktop.org (Postfix) with ESMTP id 48F066E08D for ; Thu, 20 Mar 2014 06:46:59 -0700 (PDT) Received: by mail-ee0-f45.google.com with SMTP id d17so687094eek.32 for ; Thu, 20 Mar 2014 06:46:58 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140320073052.GI4890@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , Ben Widawsky , Intel GFX List-Id: intel-gfx@lists.freedesktop.org On Thu, Mar 20, 2014 at 07:30:52AM +0000, Chris Wilson wrote: > On Wed, Mar 19, 2014 at 06:31:13PM -0700, Ben Widawsky wrote: > > With the renamed RPS struct members, it's easier to skip the local > > variables which no longer clarify anything, and if anything just make > > the code harder to read. > > > > The real motivation for this patch is actually the next patch, which > > attempts to consolidate some of the functionality. > > > > Cc: Jeff McGee > > Signed-off-by: Ben Widawsky > Reviewed-by: Chris Wilson Merged up to this one to not have a badly diverging codebase between 3.15 and later kernels. Thanks for patches&review. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch