From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38406)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1WQdk0-0003s9-DR
	for qemu-devel@nongnu.org; Thu, 20 Mar 2014 10:14:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1WQdju-0000jV-3w
	for qemu-devel@nongnu.org; Thu, 20 Mar 2014 10:14:40 -0400
Received: from mx1.redhat.com ([209.132.183.28]:39831)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1WQdjt-0000jN-R6
	for qemu-devel@nongnu.org; Thu, 20 Mar 2014 10:14:34 -0400
Date: Thu, 20 Mar 2014 15:14:29 +0100
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20140320141429.GA2570@stefanha-thinkpad.redhat.com>
References: <1394436721-21812-1-git-send-email-cyliu@suse.com>
	<1394436721-21812-14-git-send-email-cyliu@suse.com>
	<20140311142451.GM7761@stefanha-thinkpad.redhat.com>
	<532B4AA70200006600032AB7@soto.provo.novell.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <532B4AA70200006600032AB7@soto.provo.novell.com>
Subject: Re: [Qemu-devel] [PATCH v22 13/25] qed.c: replace
 QEMUOptionParameter with QemuOpts
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Chun Yan Liu <cyliu@suse.com>
Cc: kwolf@redhat.com, Stefan Hajnoczi <stefanha@gmail.com>, Dong Xu Wang <wdongxu@linux.vnet.ibm.com>, qemu-devel@nongnu.org

On Thu, Mar 20, 2014 at 03:08:07AM -0600, Chun Yan Liu wrote:
> 
> 
> >>> On 3/11/2014 at 10:24 PM, in message
> <20140311142451.GM7761@stefanha-thinkpad.redhat.com>, Stefan Hajnoczi
> <stefanha@gmail.com> wrote: 
> > On Mon, Mar 10, 2014 at 03:31:49PM +0800, Chunyan Liu wrote: 
> > > diff --git a/block/qed.h b/block/qed.h 
> > > index 5d65bea..b024751 100644 
> > > --- a/block/qed.h 
> > > +++ b/block/qed.h 
> > > @@ -43,7 +43,7 @@ 
> > >   * 
> > >   * All fields are little-endian on disk. 
> > >   */ 
> > > - 
> > > +#define  QED_DEFAULT_CLUSTER_SIZE  65536 
> > >  enum { 
> > >      QED_MAGIC = 'Q' | 'E' << 8 | 'D' << 16 | '\0' << 24, 
> > >   
> > > @@ -69,7 +69,6 @@ enum { 
> > >       */ 
> > >      QED_MIN_CLUSTER_SIZE = 4 * 1024, /* in bytes */ 
> > >      QED_MAX_CLUSTER_SIZE = 64 * 1024 * 1024, 
> > > -    QED_DEFAULT_CLUSTER_SIZE = 64 * 1024, 
> >  
> > Why is this change made for cluster size but not table size? 
> 
> According to existing create_options, "cluster size" has default value = 
> QED_DEFAULT_CLUSTER_SIZE, after switching to create_opts, this has to be 
> stringized and set to .def_value_str. That is, 
>  .def_value_str = stringify(QED_DEFAULT_CLUSTER_SIZE), 
> so the QED_DEFAULT_CLUSTER_SIZE could not be a expression, here changes. 
> "table size" has no default value in create_options, not need such changes

Okay, thanks!