From mboxrd@z Thu Jan 1 00:00:00 1970 From: moinejf@free.fr (Jean-Francois Moine) Date: Thu, 20 Mar 2014 14:52:21 +0100 Subject: [PATCH] ASoC: tda998x: Fix lack of required reg in DT documentation In-Reply-To: <532AEDE2.3080306@gmail.com> References: <20140320092639.48F68A6279@smtp3-g21.free.fr> <532ADFD8.80301@gmail.com> <20140320140156.5d768b1f@armhf> <532AEDE2.3080306@gmail.com> Message-ID: <20140320145221.09252bf6@armhf> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, 20 Mar 2014 14:32:18 +0100 Sebastian Hesselbarth wrote: > Ok, I had another round of google'ing and found this: > http://hipstercircuits.com/wp-content/uploads/2013/05/TDA19988.pdf > > There, the datasheet specifically for TDA19988 only states 0x70 and > 0x34 as the two i2c addresses. Therefore, TDA19988 has fixed i2c > addresses while TDA9983b has configurable (main) i2c address. > > Not as easy as we thought ;) > > I suggest reword the reg property to: > "- reg: shall be set to the I2C address" > > and optionally list all known addresses for each TDA[1]998x in the > binding. Thanks for the link. OK, then, as the linux tda998x driver handles only the tda 19988 and 19989 chips, the HDMI I2C address is always 0x70. So, question: Russell and Sebastian, do you still want an other patch? Other question: the CEC address is hard-coded to 0x34 in the driver. Should it be configurable in the DT? -- Ken ar c'henta? | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Francois Moine Subject: Re: [PATCH] ASoC: tda998x: Fix lack of required reg in DT documentation Date: Thu, 20 Mar 2014 14:52:21 +0100 Message-ID: <20140320145221.09252bf6@armhf> References: <20140320092639.48F68A6279@smtp3-g21.free.fr> <532ADFD8.80301@gmail.com> <20140320140156.5d768b1f@armhf> <532AEDE2.3080306@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <532AEDE2.3080306@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sebastian Hesselbarth Cc: devicetree@vger.kernel.org, Russell King - ARM Linux , linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: devicetree@vger.kernel.org T24gVGh1LCAyMCBNYXIgMjAxNCAxNDozMjoxOCArMDEwMApTZWJhc3RpYW4gSGVzc2VsYmFydGgg PHNlYmFzdGlhbi5oZXNzZWxiYXJ0aEBnbWFpbC5jb20+IHdyb3RlOgoKPiBPaywgSSBoYWQgYW5v dGhlciByb3VuZCBvZiBnb29nbGUnaW5nIGFuZCBmb3VuZCB0aGlzOgo+IGh0dHA6Ly9oaXBzdGVy Y2lyY3VpdHMuY29tL3dwLWNvbnRlbnQvdXBsb2Fkcy8yMDEzLzA1L1REQTE5OTg4LnBkZgo+IAo+ IFRoZXJlLCB0aGUgZGF0YXNoZWV0IHNwZWNpZmljYWxseSBmb3IgVERBMTk5ODggb25seSBzdGF0 ZXMgMHg3MCBhbmQKPiAweDM0IGFzIHRoZSB0d28gaTJjIGFkZHJlc3Nlcy4gVGhlcmVmb3JlLCBU REExOTk4OCBoYXMgZml4ZWQgaTJjCj4gYWRkcmVzc2VzIHdoaWxlIFREQTk5ODNiIGhhcyBjb25m aWd1cmFibGUgKG1haW4pIGkyYyBhZGRyZXNzLgo+IAo+IE5vdCBhcyBlYXN5IGFzIHdlIHRob3Vn aHQgOykKPiAKPiBJIHN1Z2dlc3QgcmV3b3JkIHRoZSByZWcgcHJvcGVydHkgdG86Cj4gIi0gcmVn OiBzaGFsbCBiZSBzZXQgdG8gdGhlIEkyQyBhZGRyZXNzIgo+IAo+IGFuZCBvcHRpb25hbGx5IGxp c3QgYWxsIGtub3duIGFkZHJlc3NlcyBmb3IgZWFjaCBUREFbMV05OTh4IGluIHRoZQo+IGJpbmRp bmcuCgpUaGFua3MgZm9yIHRoZSBsaW5rLgoKT0ssIHRoZW4sIGFzIHRoZSBsaW51eCB0ZGE5OTh4 IGRyaXZlciBoYW5kbGVzIG9ubHkgdGhlIHRkYSAxOTk4OCBhbmQKMTk5ODkgY2hpcHMsIHRoZSBI RE1JIEkyQyBhZGRyZXNzIGlzIGFsd2F5cyAweDcwLgoKU28sIHF1ZXN0aW9uOiBSdXNzZWxsIGFu ZCBTZWJhc3RpYW4sIGRvIHlvdSBzdGlsbCB3YW50IGFuIG90aGVyIHBhdGNoPwoKT3RoZXIgcXVl c3Rpb246IHRoZSBDRUMgYWRkcmVzcyBpcyBoYXJkLWNvZGVkIHRvIDB4MzQgaW4gdGhlIGRyaXZl ci4KU2hvdWxkIGl0IGJlIGNvbmZpZ3VyYWJsZSBpbiB0aGUgRFQ/CgotLSAKS2VuIGFyIGMnaGVu dGHDsQl8CSAgICAgICoqIEJyZWl6aCBoYSBMaW51eCBhdGF2ISAqKgpKZWYJCXwJCWh0dHA6Ly9t b2luZWpmLmZyZWUuZnIvCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRl dmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759089AbaCTNwL (ORCPT ); Thu, 20 Mar 2014 09:52:11 -0400 Received: from smtp3-g21.free.fr ([212.27.42.3]:37243 "EHLO smtp3-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759031AbaCTNwH convert rfc822-to-8bit (ORCPT ); Thu, 20 Mar 2014 09:52:07 -0400 Date: Thu, 20 Mar 2014 14:52:21 +0100 From: Jean-Francois Moine To: Sebastian Hesselbarth Cc: Russell King - ARM Linux , devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: tda998x: Fix lack of required reg in DT documentation Message-ID: <20140320145221.09252bf6@armhf> In-Reply-To: <532AEDE2.3080306@gmail.com> References: <20140320092639.48F68A6279@smtp3-g21.free.fr> <532ADFD8.80301@gmail.com> <20140320140156.5d768b1f@armhf> <532AEDE2.3080306@gmail.com> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.22; arm-unknown-linux-gnueabihf) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 20 Mar 2014 14:32:18 +0100 Sebastian Hesselbarth wrote: > Ok, I had another round of google'ing and found this: > http://hipstercircuits.com/wp-content/uploads/2013/05/TDA19988.pdf > > There, the datasheet specifically for TDA19988 only states 0x70 and > 0x34 as the two i2c addresses. Therefore, TDA19988 has fixed i2c > addresses while TDA9983b has configurable (main) i2c address. > > Not as easy as we thought ;) > > I suggest reword the reg property to: > "- reg: shall be set to the I2C address" > > and optionally list all known addresses for each TDA[1]998x in the > binding. Thanks for the link. OK, then, as the linux tda998x driver handles only the tda 19988 and 19989 chips, the HDMI I2C address is always 0x70. So, question: Russell and Sebastian, do you still want an other patch? Other question: the CEC address is hard-coded to 0x34 in the driver. Should it be configurable in the DT? -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/