From: Matt Porter <mporter@linaro.org>
To: Axel Lin <axel.lin@ingics.com>
Cc: Mark Brown <broonie@kernel.org>,
Tim Kryger <tim.kryger@linaro.org>,
Markus Mayer <markus.mayer@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] regulator: bcm590xx: Remove **rdev from struct bcm590xx_reg
Date: Thu, 20 Mar 2014 11:21:42 -0400 [thread overview]
Message-ID: <20140320152142.GK25092@beef> (raw)
In-Reply-To: <1394762347.8460.3.camel@phoenix>
On Fri, Mar 14, 2014 at 09:59:07AM +0800, Axel Lin wrote:
> The **rdev of 'struct bcm590xx_reg' isn't used anywhere in the driver so
> remove it.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/regulator/bcm590xx-regulator.c | 10 ----------
> 1 file changed, 10 deletions(-)
Looks good, thanks for catching this.
Acked-by: Matt Porter <mporter@linaro.org>
>
> diff --git a/drivers/regulator/bcm590xx-regulator.c b/drivers/regulator/bcm590xx-regulator.c
> index d12d6d6..ab08ca7 100644
> --- a/drivers/regulator/bcm590xx-regulator.c
> +++ b/drivers/regulator/bcm590xx-regulator.c
> @@ -153,7 +153,6 @@ static struct bcm590xx_info bcm590xx_regs[] = {
> struct bcm590xx_reg {
> struct regulator_desc *desc;
> struct bcm590xx *mfd;
> - struct regulator_dev **rdev;
> struct bcm590xx_info **info;
> };
>
> @@ -334,13 +333,6 @@ static int bcm590xx_probe(struct platform_device *pdev)
> return -ENOMEM;
> }
>
> - pmu->rdev = devm_kzalloc(&pdev->dev, BCM590XX_NUM_REGS *
> - sizeof(struct regulator_dev *), GFP_KERNEL);
> - if (!pmu->rdev) {
> - dev_err(&pdev->dev, "Memory alloc fails for rdev\n");
> - return -ENOMEM;
> - }
> -
> info = bcm590xx_regs;
>
> for (i = 0; i < BCM590XX_NUM_REGS; i++, info++) {
> @@ -391,8 +383,6 @@ static int bcm590xx_probe(struct platform_device *pdev)
> pdev->name);
> return PTR_ERR(rdev);
> }
> -
> - pmu->rdev[i] = rdev;
> }
>
> return 0;
> --
> 1.8.1.2
>
>
>
next prev parent reply other threads:[~2014-03-20 15:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-14 1:57 [PATCH 1/3] regulator: bcm590xx: Make the modalias matches the driver name Axel Lin
2014-03-14 1:59 ` [PATCH 2/3] regulator: bcm590xx: Remove **rdev from struct bcm590xx_reg Axel Lin
2014-03-20 15:21 ` Matt Porter [this message]
2014-03-21 18:10 ` Mark Brown
2014-03-14 2:00 ` [PATCH 3/3] regulator: bcm590xx: Use array to save desc and *info Axel Lin
2014-03-20 15:42 ` Matt Porter
2014-03-21 0:58 ` Axel Lin
2014-03-21 18:09 ` [PATCH 1/3] regulator: bcm590xx: Make the modalias matches the driver name Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140320152142.GK25092@beef \
--to=mporter@linaro.org \
--cc=axel.lin@ingics.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markus.mayer@linaro.org \
--cc=tim.kryger@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.