From: alexandre.belloni@free-electrons.com (Alexandre Belloni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Documentation: dt: list all compatible strings for at91
Date: Thu, 20 Mar 2014 17:21:00 +0100 [thread overview]
Message-ID: <20140320162100.GU12021@piout.net> (raw)
In-Reply-To: <CAL_Jsq+sctq85ZhqKyVa7=r5A0FEDKu36692rRJufyca1gzF6g@mail.gmail.com>
Hi Rob,
On 19/03/2014 at 11:14:43 -0500, Rob Herring wrote :
> On Wed, Mar 19, 2014 at 5:26 AM, Alexandre Belloni
> <alexandre.belloni@free-electrons.com> wrote:
> > Avoids getting the newly introduced warning:
> > WARNING: DT compatible string "atmel,at91sam9g45-adc" appears un-documented -- check ./Documentation/devicetree/bindings/
> > + compatible = "atmel,at91sam9g45-adc";
> >
> > Introduced by:
> > bff5da433525 checkpatch: add DT compatible string documentation checks
>
> We should fix checkpatch instead. There are some fixes in progress,
> but I don't think it covers this issue. I'm puzzled by this one as I
> thought I checked for this case.
>
Will someone take care of it ? I'm not sure how you want to handle that
as <chip> is replacing different values depending on the context. Also,
while for atmel and freescale, it is replacing the full chip name, that
is not the case for nvidia...
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Rob Herring <robherring2@gmail.com>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] Documentation: dt: list all compatible strings for at91
Date: Thu, 20 Mar 2014 17:21:00 +0100 [thread overview]
Message-ID: <20140320162100.GU12021@piout.net> (raw)
In-Reply-To: <CAL_Jsq+sctq85ZhqKyVa7=r5A0FEDKu36692rRJufyca1gzF6g@mail.gmail.com>
Hi Rob,
On 19/03/2014 at 11:14:43 -0500, Rob Herring wrote :
> On Wed, Mar 19, 2014 at 5:26 AM, Alexandre Belloni
> <alexandre.belloni@free-electrons.com> wrote:
> > Avoids getting the newly introduced warning:
> > WARNING: DT compatible string "atmel,at91sam9g45-adc" appears un-documented -- check ./Documentation/devicetree/bindings/
> > + compatible = "atmel,at91sam9g45-adc";
> >
> > Introduced by:
> > bff5da433525 checkpatch: add DT compatible string documentation checks
>
> We should fix checkpatch instead. There are some fixes in progress,
> but I don't think it covers this issue. I'm puzzled by this one as I
> thought I checked for this case.
>
Will someone take care of it ? I'm not sure how you want to handle that
as <chip> is replacing different values depending on the context. Also,
while for atmel and freescale, it is replacing the full chip name, that
is not the case for nvidia...
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-03-20 16:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-19 10:26 [PATCH] Documentation: dt: list all compatible strings for at91 Alexandre Belloni
2014-03-19 10:26 ` Alexandre Belloni
2014-03-19 10:33 ` Nicolas Ferre
2014-03-19 10:33 ` Nicolas Ferre
2014-03-19 10:46 ` Alexandre Belloni
2014-03-19 10:46 ` Alexandre Belloni
2014-03-19 16:14 ` Rob Herring
2014-03-19 16:14 ` Rob Herring
2014-03-20 16:21 ` Alexandre Belloni [this message]
2014-03-20 16:21 ` Alexandre Belloni
2014-03-21 11:14 ` Alexandre Belloni
2014-03-21 11:14 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140320162100.GU12021@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.