From mboxrd@z Thu Jan 1 00:00:00 1970 From: moinejf@free.fr (Jean-Francois Moine) Date: Thu, 20 Mar 2014 16:54:40 +0100 Subject: [PATCH] ASoC: tda998x: Fix lack of required reg in DT documentation In-Reply-To: <20140320151934.GV7528@n2100.arm.linux.org.uk> References: <20140320092639.48F68A6279@smtp3-g21.free.fr> <532ADFD8.80301@gmail.com> <20140320140156.5d768b1f@armhf> <532AEDE2.3080306@gmail.com> <20140320145221.09252bf6@armhf> <20140320143110.GU7528@n2100.arm.linux.org.uk> <20140320155935.7a474173@armhf> <20140320151934.GV7528@n2100.arm.linux.org.uk> Message-ID: <20140320165440.195cd2ea@armhf> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, 20 Mar 2014 15:19:34 +0000 Russell King - ARM Linux wrote: > I'm not saying that it has to match the physical device fitted - I'm > merely suggesting not using nxp,tda1998x which could (and as Sebastian > has found, does) conflict with other devices with different properties. > > We still auto-detect the exact device type by reading the ID register > because that's the most reliable way to detect exactly what kind of > device is fitted to the board. I don't see the problem. Actually the driver handles the tda9989, tda19988 and tda19989 (2 variants). If some board has, for example, the tda9983 and if the driver is extended to handle this chip (i.e. mainly ignore the CEC part), setting 'nxp,tda998x' in the associated DT will still work. There could be a problem if somebody would write a specific driver for, say, a tda9985. But, then, the compatible would be 'nxp,tda9985'. -- Ken ar c'henta? | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Francois Moine Subject: Re: [PATCH] ASoC: tda998x: Fix lack of required reg in DT documentation Date: Thu, 20 Mar 2014 16:54:40 +0100 Message-ID: <20140320165440.195cd2ea@armhf> References: <20140320092639.48F68A6279@smtp3-g21.free.fr> <532ADFD8.80301@gmail.com> <20140320140156.5d768b1f@armhf> <532AEDE2.3080306@gmail.com> <20140320145221.09252bf6@armhf> <20140320143110.GU7528@n2100.arm.linux.org.uk> <20140320155935.7a474173@armhf> <20140320151934.GV7528@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20140320151934.GV7528@n2100.arm.linux.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Russell King - ARM Linux Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, Sebastian Hesselbarth List-Id: devicetree@vger.kernel.org T24gVGh1LCAyMCBNYXIgMjAxNCAxNToxOTozNCArMDAwMApSdXNzZWxsIEtpbmcgLSBBUk0gTGlu dXggPGxpbnV4QGFybS5saW51eC5vcmcudWs+IHdyb3RlOgoKPiBJJ20gbm90IHNheWluZyB0aGF0 IGl0IGhhcyB0byBtYXRjaCB0aGUgcGh5c2ljYWwgZGV2aWNlIGZpdHRlZCAtIEknbQo+IG1lcmVs eSBzdWdnZXN0aW5nIG5vdCB1c2luZyBueHAsdGRhMTk5OHggd2hpY2ggY291bGQgKGFuZCBhcyBT ZWJhc3RpYW4KPiBoYXMgZm91bmQsIGRvZXMpIGNvbmZsaWN0IHdpdGggb3RoZXIgZGV2aWNlcyB3 aXRoIGRpZmZlcmVudCBwcm9wZXJ0aWVzLgo+IAo+IFdlIHN0aWxsIGF1dG8tZGV0ZWN0IHRoZSBl eGFjdCBkZXZpY2UgdHlwZSBieSByZWFkaW5nIHRoZSBJRCByZWdpc3Rlcgo+IGJlY2F1c2UgdGhh dCdzIHRoZSBtb3N0IHJlbGlhYmxlIHdheSB0byBkZXRlY3QgZXhhY3RseSB3aGF0IGtpbmQgb2YK PiBkZXZpY2UgaXMgZml0dGVkIHRvIHRoZSBib2FyZC4KCkkgZG9uJ3Qgc2VlIHRoZSBwcm9ibGVt LgoKQWN0dWFsbHkgdGhlIGRyaXZlciBoYW5kbGVzIHRoZSB0ZGE5OTg5LCB0ZGExOTk4OCBhbmQg dGRhMTk5ODkgKDIKdmFyaWFudHMpLiBJZiBzb21lIGJvYXJkIGhhcywgZm9yIGV4YW1wbGUsIHRo ZSB0ZGE5OTgzIGFuZCBpZiB0aGUKZHJpdmVyIGlzIGV4dGVuZGVkIHRvIGhhbmRsZSB0aGlzIGNo aXAgKGkuZS4gbWFpbmx5IGlnbm9yZSB0aGUgQ0VDCnBhcnQpLCBzZXR0aW5nICdueHAsdGRhOTk4 eCcgaW4gdGhlIGFzc29jaWF0ZWQgRFQgd2lsbCBzdGlsbCB3b3JrLgoKVGhlcmUgY291bGQgYmUg YSBwcm9ibGVtIGlmIHNvbWVib2R5IHdvdWxkIHdyaXRlIGEgc3BlY2lmaWMgZHJpdmVyIGZvciwK c2F5LCBhIHRkYTk5ODUuIEJ1dCwgdGhlbiwgdGhlIGNvbXBhdGlibGUgd291bGQgYmUgJ254cCx0 ZGE5OTg1Jy4KCi0tIApLZW4gYXIgYydoZW50YcOxCXwJICAgICAgKiogQnJlaXpoIGhhIExpbnV4 IGF0YXYhICoqCkplZgkJfAkJaHR0cDovL21vaW5lamYuZnJlZS5mci8KX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApk cmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758292AbaCTPyc (ORCPT ); Thu, 20 Mar 2014 11:54:32 -0400 Received: from smtp4-g21.free.fr ([212.27.42.4]:40001 "EHLO smtp4-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751671AbaCTPya convert rfc822-to-8bit (ORCPT ); Thu, 20 Mar 2014 11:54:30 -0400 Date: Thu, 20 Mar 2014 16:54:40 +0100 From: Jean-Francois Moine To: Russell King - ARM Linux Cc: Sebastian Hesselbarth , devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: tda998x: Fix lack of required reg in DT documentation Message-ID: <20140320165440.195cd2ea@armhf> In-Reply-To: <20140320151934.GV7528@n2100.arm.linux.org.uk> References: <20140320092639.48F68A6279@smtp3-g21.free.fr> <532ADFD8.80301@gmail.com> <20140320140156.5d768b1f@armhf> <532AEDE2.3080306@gmail.com> <20140320145221.09252bf6@armhf> <20140320143110.GU7528@n2100.arm.linux.org.uk> <20140320155935.7a474173@armhf> <20140320151934.GV7528@n2100.arm.linux.org.uk> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.22; arm-unknown-linux-gnueabihf) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 20 Mar 2014 15:19:34 +0000 Russell King - ARM Linux wrote: > I'm not saying that it has to match the physical device fitted - I'm > merely suggesting not using nxp,tda1998x which could (and as Sebastian > has found, does) conflict with other devices with different properties. > > We still auto-detect the exact device type by reading the ID register > because that's the most reliable way to detect exactly what kind of > device is fitted to the board. I don't see the problem. Actually the driver handles the tda9989, tda19988 and tda19989 (2 variants). If some board has, for example, the tda9983 and if the driver is extended to handle this chip (i.e. mainly ignore the CEC part), setting 'nxp,tda998x' in the associated DT will still work. There could be a problem if somebody would write a specific driver for, say, a tda9985. But, then, the compatible would be 'nxp,tda9985'. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/