From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerome Glisse <j.glisse@gmail.com>
Subject: Re: [PATCH v2] drm: enable render-nodes by default
Date: Thu, 20 Mar 2014 13:04:56 -0400
Message-ID: <20140320170454.GD2020@gmail.com>
References: <CANq1E4Sbzx2YBPn622TdLH58jshbuj_BG7PDoDtDc1_eu1CZVw@mail.gmail.com>
 <532AAB78.6010500@vmware.com>
 <CANq1E4S9rLLGhH6R9ELtzkrqzwbY54ErVEY37vNmOSCVrvXFEg@mail.gmail.com>
 <532AB481.40309@vmware.com>
 <CANq1E4QtMRqTg7keM+uPPDXM4OOTkYmutHzGvsY6bkR+oAjKVQ@mail.gmail.com>
 <532AC2C2.5030606@vmware.com> <20140320143600.GA2020@gmail.com>
 <532B0245.7050504@vmware.com> <20140320153423.GB2020@gmail.com>
 <532B0E16.2080005@shipmail.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mail-qc0-f175.google.com (mail-qc0-f175.google.com
 [209.85.216.175])
 by gabe.freedesktop.org (Postfix) with ESMTP id 7338C6E145
 for <dri-devel@lists.freedesktop.org>; Thu, 20 Mar 2014 10:05:00 -0700 (PDT)
Received: by mail-qc0-f175.google.com with SMTP id e16so1363861qcx.34
 for <dri-devel@lists.freedesktop.org>; Thu, 20 Mar 2014 10:04:59 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <532B0E16.2080005@shipmail.org>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Thomas Hellstrom <thomas@shipmail.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Thomas Hellstrom <thellstrom@vmware.com>, "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>
List-Id: dri-devel@lists.freedesktop.org

On Thu, Mar 20, 2014 at 04:49:42PM +0100, Thomas Hellstrom wrote:
> On 03/20/2014 04:34 PM, Jerome Glisse wrote:
> > On Thu, Mar 20, 2014 at 03:59:17PM +0100, Thomas Hellstrom wrote:
> >> On 03/20/2014 03:36 PM, Jerome Glisse wrote:
> >>> In any case this is not a render node issue and there is no reasons t=
o force
> >>> full VRAM eviction or anything like that.
> >> This comment suggests you haven't read the discussion fully.
> >>
> >> VRAM eviction was discussed in the context of legacy nodes.
> >>
> >> This is a render node issue because with legacy nodes you can work
> >> around insufficient command checking.
> >> With render nodes you can't.
> > On radeon you can not abuse the GPU period legacy node or not. My comme=
nt
> > was about the fact that this is a driver issue and not a render node is=
sue.
> > I would consider driver that allow to abuse the GPU block to access any
> > memory as broken no matter if we are talking about legacy or new render
> > node.
> >
> > Cheers,
> > J=E9r=F4me
> >
> =

> Great. Then I assume you don't have an issue with not enabling
> render-nodes for those broken drivers,
> (or at least a sysfs property or something similar flagging those device
> nodes as broken)?
> =

> Thanks,
> Thomas
> =

> =


Yes, broken driver should not have render node, at leadt in my view.

Cheers,
J=E9r=F4me