From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] regulator: Add new driver for ST's PWM controlled voltage regulators
Date: Thu, 20 Mar 2014 17:31:55 +0000 [thread overview]
Message-ID: <20140320173155.GG11706@sirena.org.uk> (raw)
In-Reply-To: <1395324654-8235-1-git-send-email-lee.jones@linaro.org>
On Thu, Mar 20, 2014 at 02:10:54PM +0000, Lee Jones wrote:
> + dev_info(&pdev->dev, "ST PWM Regulator registered\n");
Remove this, it's not adding anything really (the core is pretty chatty
already). Otherwise this all seems fine modulo the issues Josh
mentioned.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140320/adbe3db3/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kernel-F5mvAk5X5gdBDgjK7y7TUQ@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/1] regulator: Add new driver for ST's PWM controlled voltage regulators
Date: Thu, 20 Mar 2014 17:31:55 +0000 [thread overview]
Message-ID: <20140320173155.GG11706@sirena.org.uk> (raw)
In-Reply-To: <1395324654-8235-1-git-send-email-lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 267 bytes --]
On Thu, Mar 20, 2014 at 02:10:54PM +0000, Lee Jones wrote:
> + dev_info(&pdev->dev, "ST PWM Regulator registered\n");
Remove this, it's not adding anything really (the core is pretty chatty
already). Otherwise this all seems fine modulo the issues Josh
mentioned.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@stlinux.com,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/1] regulator: Add new driver for ST's PWM controlled voltage regulators
Date: Thu, 20 Mar 2014 17:31:55 +0000 [thread overview]
Message-ID: <20140320173155.GG11706@sirena.org.uk> (raw)
In-Reply-To: <1395324654-8235-1-git-send-email-lee.jones@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 267 bytes --]
On Thu, Mar 20, 2014 at 02:10:54PM +0000, Lee Jones wrote:
> + dev_info(&pdev->dev, "ST PWM Regulator registered\n");
Remove this, it's not adding anything really (the core is pretty chatty
already). Otherwise this all seems fine modulo the issues Josh
mentioned.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-03-20 17:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-20 14:10 [PATCH 1/1] regulator: Add new driver for ST's PWM controlled voltage regulators Lee Jones
2014-03-20 14:10 ` Lee Jones
2014-03-20 15:28 ` Josh Cartwright
2014-03-20 15:28 ` Josh Cartwright
2014-03-20 15:48 ` Lee Jones
2014-03-20 15:48 ` Lee Jones
2014-03-20 16:09 ` Josh Cartwright
2014-03-20 16:09 ` Josh Cartwright
2014-03-20 16:09 ` Josh Cartwright
2014-03-20 17:31 ` Mark Brown [this message]
2014-03-20 17:31 ` Mark Brown
2014-03-20 17:31 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140320173155.GG11706@sirena.org.uk \
--to=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.