From: Oleg Nesterov <oleg@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Peng Tao <bergwolf@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Oleg Drokin <oleg.drokin@intel.com>,
Andreas Dilger <andreas.dilger@intel.com>
Subject: [PATCH 0/2] wait: introduce WQ_FLAG_EXCLUSIVE_HEAD
Date: Thu, 20 Mar 2014 18:51:11 +0100 [thread overview]
Message-ID: <20140320175111.GA7375@redhat.com> (raw)
In-Reply-To: <20140319171906.GA11377@redhat.com>
On 03/19, Oleg Nesterov wrote:
>
> OK, I'll try to test/cleanup/resend tomorrow.
Cough. Still un-tested, sorry. I will test it somehow and report,
but I'd like to send this for review right now.
Because I simply can't decide what the new flag should actually
do, so please ack/nack the semantics/naming at least.
Changes:
1. I decided it would be better to change __wait_event()
to accept wait.flags right now. This looks better in
any case to me, and otherwise we need to introduce the
__wait_exclusive_enum.
The change looks trivial (both actually), please tell
me if you think it doesn't deserve a separate patch.
2. I won't insist, but WQ_FLAG_EXCLUSIVE_HEAD can be used
without WQ_FLAG_EXCLUSIVE.
Unlikely this can be useful, but it looks more natural
this way. Otherwise we need to add another check to
ensure that WQ_FLAG_EXCLUSIVE_HEAD can't come alone.
However, perhaps this means the new flag needs another
name. I agree in advance with any.
Oleg.
next prev parent reply other threads:[~2014-03-20 17:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-18 13:10 [PATCH RFC] sched: introduce add_wait_queue_exclusive_head Peng Tao
2014-03-18 13:33 ` Peter Zijlstra
2014-03-18 13:51 ` Peng Tao
2014-03-18 14:05 ` Peter Zijlstra
2014-03-18 14:44 ` Peng Tao
2014-03-18 16:23 ` Oleg Nesterov
2014-03-19 2:22 ` Peng Tao
2014-03-19 17:33 ` Oleg Nesterov
2014-03-19 19:44 ` Dilger, Andreas
2014-03-19 19:55 ` Peter Zijlstra
2014-03-20 7:06 ` Dilger, Andreas
2014-03-20 18:49 ` Oleg Nesterov
2014-03-18 15:47 ` Oleg Nesterov
2014-03-19 2:17 ` Peng Tao
[not found] ` <20140319164907.GA10113@redhat.com>
2014-03-19 16:57 ` Peter Zijlstra
2014-03-19 17:19 ` Oleg Nesterov
2014-03-20 17:51 ` Oleg Nesterov [this message]
2014-03-20 17:51 ` [PATCH 1/2] wait: turn "bool exclusive" arg of __wait_event() into wflags Oleg Nesterov
2014-03-20 17:51 ` [PATCH 2/2] wait: introduce WQ_FLAG_EXCLUSIVE_HEAD Oleg Nesterov
2014-03-21 2:45 ` [PATCH 0/2] " Dilger, Andreas
2014-03-21 18:49 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140320175111.GA7375@redhat.com \
--to=oleg@redhat.com \
--cc=andreas.dilger@intel.com \
--cc=bergwolf@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=oleg.drokin@intel.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.