From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [arm arch] local_irq_restore() does not play well with local_fiq_enable()
Date: Thu, 20 Mar 2014 20:02:34 +0000 [thread overview]
Message-ID: <20140320200233.GC7528@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <op.xc1dkcblfh00o9@enterprised.lan>
On Thu, Mar 20, 2014 at 07:54:02PM +0000, Jonathan Bell wrote:
> hcd_init:
> setup the FIQ state
> install the fiq handler
> enable_fiq(USB)
> local_fiq_enable()
> usb_add_hcd()
You're not supposed to use local_fiq_enable() to enable FIQs in a device
driver - they should already be enabled by this point.
There has been a hole in that where FIQs haven't been enabled in the
idle thread, but that's a bug which needs fixing. Otherwise, you should
assume that FIQs are always unmasked everywhere except for any short
code sequences that are contained within a short local_fiq_disable()..
local_fiq_enable() block.
--
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
next prev parent reply other threads:[~2014-03-20 20:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-20 19:54 [arm arch] local_irq_restore() does not play well with local_fiq_enable() Jonathan Bell
2014-03-20 20:02 ` Russell King - ARM Linux [this message]
2014-03-20 20:49 ` Jonathan Bell
2014-03-20 21:09 ` Russell King - ARM Linux
2014-03-23 18:38 ` Jonathan Bell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140320200233.GC7528@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.