All of lore.kernel.org
 help / color / mirror / Atom feed
From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Matt Sickler <Matt.Sickler@daktronics.com>
Cc: "hjk@hansjkoch.de" <hjk@hansjkoch.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH]: UIO read(2)/write(2) overrides
Date: Fri, 21 Mar 2014 07:24:29 -0700	[thread overview]
Message-ID: <20140321142429.GA25833@kroah.com> (raw)
In-Reply-To: <8FAD17D1809CB042A0963E8337B9FE3DD7D823@MB-EXC-04.daktronics.lan>

On Fri, Mar 21, 2014 at 02:20:11PM +0000, Matt Sickler wrote:
> Tiny patch to let uio-based drivers override the read(2), write(2), and poll(2) syscalls.
> The rationale is that some uio-based drivers might want the mmap(2) functionality
> of UIO, but have no need for the IRQ semantics of read(2) and write(2).

Can you submit a driver that uses these new interfaces as well?  I don't
want to add something that isn't used in the kernel.

> 
> Signed-Off-by: Matt Sickler <Matt.Sickler@daktronics.com>
> ---
> diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c
> index a673e5b..da1bfc8 100644
> --- a/drivers/uio/uio.c
> +++ b/drivers/uio/uio.c
> @@ -505,6 +505,9 @@ static unsigned int uio_poll(struct file *filep, poll_table *wait)
>     struct uio_listener *listener = filep->private_data;
>     struct uio_device *idev = listener->dev;
> 
> +   if (idev->info->poll)
> +       return idev->info->poll(filep, wait);
> +

Your email client ate all the tabs and created a patch that can't be
applied :(


  reply	other threads:[~2014-03-21 14:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-21 14:20 [PATCH]: UIO read(2)/write(2) overrides Matt Sickler
2014-03-21 14:24 ` gregkh [this message]
2014-03-21 14:49   ` Matt Sickler
2014-03-21 14:59     ` gregkh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140321142429.GA25833@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Matt.Sickler@daktronics.com \
    --cc=hjk@hansjkoch.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.