Re: [PATCH] Add init script (sysv) support for busybox's ntpd

From: Martin Jansa <martin.jansa@gmail.com>
To: Laszlo Papp <lpapp@kde.org>
Cc: Koen Kooi <koen@dominion.thruhere.net>,
	Otavio Salvador <otavio@ossystems.com.br>,
	OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] Add init script (sysv) support for busybox's ntpd
Date: Fri, 21 Mar 2014 15:39:40 +0100	[thread overview]
Message-ID: <20140321143939.GI3726@jama> (raw)
In-Reply-To: <CAOMwXhNqH76QKt9hsqpeOeRTBjKUix4e0GCy8PZVkrjCdm+OAA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1938 bytes --]

On Fri, Mar 21, 2014 at 01:59:15PM +0000, Laszlo Papp wrote:
> On Thu, Mar 20, 2014 at 7:59 PM, Burton, Ross <ross.burton@intel.com> wrote:
> > On 20 March 2014 19:01, Laszlo Papp <lpapp@kde.org> wrote:
> >> This init script is adding support for sysv and no more. This is also
> >> indicated in the first line of the commit message. I am sorry, but I
> >> will not test it systemd and with other systems
> >
> > You're not being asked to test with systemd.  You're being asked to
> > add LSB-standard sysvinit-specific headers to a sysvinit script.
> 
> In my understanding, people were referring to two issues:
> 
> 1) not working with systemd and what not compat modes. This is not
> something I will test any soon.

Other people already know it's causing the issues without LSB headers,
so if you just add them, you don't need to test it with systemd, other
people who care about systemd will do that for you or at least be OK
with adding this script, because it will have LSB headers (so it should
work fine in systemd world).

> 2) It is not consistent, whereas if I take a look into busybox, the
> consistency is what I do, apparently.
> 
> I would like to quote from the Fedora wiki for instance:
> 
> "LSB Headers are not required for Fedora SysV-style initscripts, but
> they may be used. There is no requirement in the LSB certification for
> any system scripts to be LSB compliant, and it can cause issues with
> ordering."
> 
> So what is wrong about it without systemd and other compat modes? If
> it is that big a deal (i.e. blocker), perhaps it is better to document
> it in the contribution guideline as a generic trap.
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]