From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Use 64-bit DMA addresses for LPAE+VirtIO-MMIO
Date: Fri, 21 Mar 2014 16:27:50 +0000 [thread overview]
Message-ID: <20140321162750.GI13596@arm.com> (raw)
In-Reply-To: <1395250522-30031-1-git-send-email-cov@codeaurora.org>
On Wed, Mar 19, 2014 at 05:35:19PM +0000, Christopher Covington wrote:
> On an LPAE system, the physical addresses used by VirtIO-MMIO may
> be larger than 32 bits, even if the header and configuration space
> addresses fit into 32 bits. For example with the Versatile Express
> memory map using 4G memory, the following error occured when trying
> to use a VirtIO-MMIO block device.
>
> EXT2-fs (vda): error: ext2_check_page: bad entry in directory #2: :
> unaligned directory entry - offset=0, inode=3755990991, rec_len=57311,
> name_len=223
>
> To fix this, select ARCH_DMA_ADDR_T_64BIT when both LPAE and
> VIRTIO_MMIO are selected.
>
> Signed-off-by: Christopher Covington <cov@codeaurora.org>
> ---
> arch/arm/mm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mm/Kconfig b/arch/arm/mm/Kconfig
> index 1f8fed9..a62bcc9 100644
> --- a/arch/arm/mm/Kconfig
> +++ b/arch/arm/mm/Kconfig
> @@ -617,6 +617,7 @@ config ARM_LPAE
> bool "Support for the Large Physical Address Extension"
> depends on MMU && CPU_32v7 && !CPU_32v6 && !CPU_32v5 && \
> !CPU_32v4 && !CPU_32v3
> + select ARCH_DMA_ADDR_T_64BIT if VIRTIO_MMIO
That's the wrong place to enable ARCH_DMA_ADDR_T_64BIT. Do you have a
platform with >32-bit physical address space? If yes, it should be
selected there.
--
Catalin
WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Christopher Covington <cov@codeaurora.org>
Cc: Russell King <linux@arm.linux.org.uk>,
Jonathan Austin <Jonathan.Austin@arm.com>,
Nicolas Pitre <nico@linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: Use 64-bit DMA addresses for LPAE+VirtIO-MMIO
Date: Fri, 21 Mar 2014 16:27:50 +0000 [thread overview]
Message-ID: <20140321162750.GI13596@arm.com> (raw)
In-Reply-To: <1395250522-30031-1-git-send-email-cov@codeaurora.org>
On Wed, Mar 19, 2014 at 05:35:19PM +0000, Christopher Covington wrote:
> On an LPAE system, the physical addresses used by VirtIO-MMIO may
> be larger than 32 bits, even if the header and configuration space
> addresses fit into 32 bits. For example with the Versatile Express
> memory map using 4G memory, the following error occured when trying
> to use a VirtIO-MMIO block device.
>
> EXT2-fs (vda): error: ext2_check_page: bad entry in directory #2: :
> unaligned directory entry - offset=0, inode=3755990991, rec_len=57311,
> name_len=223
>
> To fix this, select ARCH_DMA_ADDR_T_64BIT when both LPAE and
> VIRTIO_MMIO are selected.
>
> Signed-off-by: Christopher Covington <cov@codeaurora.org>
> ---
> arch/arm/mm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mm/Kconfig b/arch/arm/mm/Kconfig
> index 1f8fed9..a62bcc9 100644
> --- a/arch/arm/mm/Kconfig
> +++ b/arch/arm/mm/Kconfig
> @@ -617,6 +617,7 @@ config ARM_LPAE
> bool "Support for the Large Physical Address Extension"
> depends on MMU && CPU_32v7 && !CPU_32v6 && !CPU_32v5 && \
> !CPU_32v4 && !CPU_32v3
> + select ARCH_DMA_ADDR_T_64BIT if VIRTIO_MMIO
That's the wrong place to enable ARCH_DMA_ADDR_T_64BIT. Do you have a
platform with >32-bit physical address space? If yes, it should be
selected there.
--
Catalin
next prev parent reply other threads:[~2014-03-21 16:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-19 17:35 [PATCH] ARM: Use 64-bit DMA addresses for LPAE+VirtIO-MMIO Christopher Covington
2014-03-19 17:35 ` Christopher Covington
2014-03-21 16:27 ` Catalin Marinas [this message]
2014-03-21 16:27 ` Catalin Marinas
2014-03-21 19:44 ` Christopher Covington
2014-03-21 19:44 ` Christopher Covington
2014-03-21 23:27 ` Catalin Marinas
2014-03-21 23:27 ` Catalin Marinas
2014-03-21 23:52 ` Arnd Bergmann
2014-03-21 23:52 ` Arnd Bergmann
2014-03-24 9:50 ` Catalin Marinas
2014-03-24 9:50 ` Catalin Marinas
2014-03-25 16:39 ` Christopher Covington
2014-03-25 16:39 ` Christopher Covington
2014-06-25 17:50 ` [PATCH v2] ARM: virt, vexpress: Use 64-bit DMA for LPAE Christopher Covington
2014-06-25 17:50 ` Christopher Covington
2014-03-24 14:14 ` [PATCH] ARM: Use 64-bit DMA addresses for LPAE+VirtIO-MMIO Christopher Covington
2014-03-24 14:14 ` Christopher Covington
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140321162750.GI13596@arm.com \
--to=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.