From: Catalin Marinas <catalin.marinas@arm.com>
To: Li Zefan <lizefan@huawei.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCH v2 3/3] kmemleak: change some global variables to int
Date: Fri, 21 Mar 2014 23:44:07 +0000 [thread overview]
Message-ID: <20140321234407.GB21429@arm.com> (raw)
In-Reply-To: <53267560.5060803@huawei.com>
On Mon, Mar 17, 2014 at 04:09:04AM +0000, Li Zefan wrote:
> They don't have to be atomic_t, because they are simple boolean
> toggles.
>
> Signed-off-by: Li Zefan <lizefan@huawei.com>
A reason for which I had atomic_t was to avoid compiler optimisations
but I don't immediately see how it could go wrong. Assuming that you
have tested it,
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Li Zefan <lizefan@huawei.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCH v2 3/3] kmemleak: change some global variables to int
Date: Fri, 21 Mar 2014 23:44:07 +0000 [thread overview]
Message-ID: <20140321234407.GB21429@arm.com> (raw)
In-Reply-To: <53267560.5060803@huawei.com>
On Mon, Mar 17, 2014 at 04:09:04AM +0000, Li Zefan wrote:
> They don't have to be atomic_t, because they are simple boolean
> toggles.
>
> Signed-off-by: Li Zefan <lizefan@huawei.com>
A reason for which I had atomic_t was to avoid compiler optimisations
but I don't immediately see how it could go wrong. Assuming that you
have tested it,
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
next prev parent reply other threads:[~2014-03-21 23:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-17 4:07 [PATCH v2 1/3] kmemleak: allow freeing internal objects after kmemleak was disabled Li Zefan
2014-03-17 4:07 ` Li Zefan
2014-03-17 4:08 ` [PATCH v2 2/3] kmemleak: remove redundant code Li Zefan
2014-03-17 4:08 ` Li Zefan
2014-03-21 23:40 ` Catalin Marinas
2014-03-21 23:40 ` Catalin Marinas
2014-03-17 4:09 ` [PATCH v2 3/3] kmemleak: change some global variables to int Li Zefan
2014-03-17 4:09 ` Li Zefan
2014-03-21 23:44 ` Catalin Marinas [this message]
2014-03-21 23:44 ` Catalin Marinas
2014-03-21 23:37 ` [PATCH v2 1/3] kmemleak: allow freeing internal objects after kmemleak was disabled Catalin Marinas
2014-03-21 23:37 ` Catalin Marinas
2014-03-27 2:29 ` Li Zefan
2014-03-27 2:29 ` Li Zefan
2014-03-27 12:21 ` Catalin Marinas
2014-03-27 12:21 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140321234407.GB21429@arm.com \
--to=catalin.marinas@arm.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizefan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.