From: tytso@mit.edu
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Fabian Frederick <fabf@skynet.be>,
linux-kernel <linux-kernel@vger.kernel.org>,
reiserfs-devel@vger.kernel.org
Subject: Re: [RFC 1/1] fs/reiserfs/journal.c: Remove obsolete __GFP_NOFAIL
Date: Sat, 22 Mar 2014 13:26:06 -0400 [thread overview]
Message-ID: <20140322172606.GB23583@thunk.org> (raw)
In-Reply-To: <20140322101512.eaeb542b.akpm@linux-foundation.org>
On Sat, Mar 22, 2014 at 10:15:12AM -0700, Andrew Morton wrote:
> > I'll note that since 2011, there has been precious little movement on
> > removing the final few callers of GFP_NOFAIL, and we still have a bit
> > under two dozen of them, including a new one in fs/buffer.c that was
> > added in 2013.
>
> Well. Converting an existing retry-for-ever caller to GFP_NOFAIL is
> good. Adding new retry-for-ever code is not good.
Actually, it wasn't converting an existing loop; it was adding a new
GFP_NOFAIL to fix a reclaim livelock (commit 84235de394d9775bf).
I agree that in ideal world, we'd get rid of all of these. But
sometimes, the cure can be worse than the disesae, and so the whole
"all callers of GFP_NOFAIL are MUST FIX BUGGGY and the maintainers
should be shamed into fixing it" attitude is one that I find a bit odd
myself.
- Ted
next prev parent reply other threads:[~2014-03-22 17:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-21 16:18 [RFC 1/1] fs/reiserfs/journal.c: Remove obsolete __GFP_NOFAIL Fabian Frederick
2014-03-21 20:00 ` Andrew Morton
2014-03-21 23:21 ` Fabian Frederick
2014-03-21 23:27 ` Andrew Morton
2014-03-22 17:03 ` tytso
2014-03-22 17:15 ` Andrew Morton
2014-03-22 17:26 ` tytso [this message]
2014-03-22 17:32 ` tytso
2014-03-22 17:55 ` Andrew Morton
2014-03-22 18:12 ` tytso
2014-03-22 18:56 ` Joe Perches
2014-03-26 1:07 ` David Rientjes
2014-03-22 19:24 ` Dave Jones
2014-03-26 1:06 ` David Rientjes
2014-03-26 6:19 ` tytso
2014-03-26 6:32 ` Andrew Morton
2014-03-26 13:29 ` tytso
2014-03-27 4:38 ` David Rientjes
2014-03-22 21:13 ` Fabian Frederick
2014-03-24 14:00 ` One Thousand Gnomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140322172606.GB23583@thunk.org \
--to=tytso@mit.edu \
--cc=akpm@linux-foundation.org \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
--cc=reiserfs-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.