From: "Michael S. Tsirkin" <mst@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Marcel Apfelbaum" <marcel.a@redhat.com>,
"Alexey Kardashevskiy" <aik@ozlabs.ru>,
"Michael Tokarev" <mjt@tls.msk.ru>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Andreas Färber" <afaerber@suse.de>,
"Richard Henderson" <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines
Date: Sun, 23 Mar 2014 11:51:33 +0200 [thread overview]
Message-ID: <20140323095133.GB6989@redhat.com> (raw)
In-Reply-To: <CAFEAcA8agvVSy-_UmCO4g+RbvqhWS=NyA7GNGNvSmg9BQZnCnQ@mail.gmail.com>
On Thu, Mar 20, 2014 at 10:17:14PM +0000, Peter Maydell wrote:
> On 20 March 2014 22:06, Marcel Apfelbaum <marcel.a@redhat.com> wrote:
> > On Thu, 2014-03-20 at 22:57 +0100, Paolo Bonzini wrote:
> >> Il 20/03/2014 22:14, Marcel Apfelbaum ha scritto:
> >> > +# All known versions of iasl on BE machines are broken.
> >> > +# TODO: add detection code once a non-broken version makes an appearance.
> >> > +if ($iasl -h > /dev/null 2>&1) &&
> >> > + (lscpu | grep "Byte Order" | grep --quiet "Little Endian" ); then
> >>
> >> lscpu is not portable.
> > I am open to suggestions...
>
> echo "trivial iasl source" | iasl --compile-options | iasl
> --disassemble-options | grep "error"
>
> Fill in the handwaving with actual syntax ;-)
>
> thanks
> -- PMM
True but whatever test we write, it's possible that a buggy iasl
passes it by luck.
Let's wait for a working iasl to appear on some BE machines.
When that happens, we'll be able to write a robust detection script.
--
MST
next prev parent reply other threads:[~2014-03-23 9:51 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-20 21:14 [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines Marcel Apfelbaum
2014-03-20 21:57 ` Paolo Bonzini
2014-03-20 22:00 ` Marcel Apfelbaum
2014-03-20 22:06 ` Marcel Apfelbaum
2014-03-20 22:17 ` Peter Maydell
2014-03-20 22:41 ` Marcel Apfelbaum
2014-03-20 23:03 ` Peter Maydell
2014-03-23 9:52 ` Michael S. Tsirkin
2014-03-23 12:31 ` Peter Maydell
2014-03-23 9:51 ` Michael S. Tsirkin [this message]
2014-03-20 22:26 ` Laszlo Ersek
2014-03-20 22:33 ` Marcel Apfelbaum
2014-03-20 22:50 ` Laszlo Ersek
2014-03-20 23:16 ` Paolo Bonzini
2014-03-23 9:49 ` Michael S. Tsirkin
2014-03-23 12:14 ` Peter Maydell
2014-03-23 12:32 ` Marcel Apfelbaum
2014-03-23 12:48 ` Peter Maydell
2014-03-23 13:00 ` Marcel Apfelbaum
2014-03-23 12:51 ` Paolo Bonzini
2014-03-23 13:17 ` Marcel Apfelbaum
2014-03-23 13:58 ` Michael S. Tsirkin
2014-03-24 11:02 ` Andreas Färber
2014-03-25 3:48 ` Alexey Kardashevskiy
2014-03-23 12:32 ` Marcel Apfelbaum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140323095133.GB6989@redhat.com \
--to=mst@redhat.com \
--cc=afaerber@suse.de \
--cc=aik@ozlabs.ru \
--cc=marcel.a@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.