From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Date: Mon, 24 Mar 2014 09:24:41 +0000 Subject: Re: [lm-sensors] [RFC V1 1/3] hwmon: da9063: HWMON driver Message-Id: <20140324092440.GN8541@lee--X1> List-Id: References: <420d4f5c8436a66b511693531cfeda131258ce69.1395607051.git.stwiss.opensource@diasemi.com> <532FA8ED.2090201@roeck-us.net> <6ED8E3B22081A4459DAC7699F3695FB7A2AFC2F2@SW-EX-MBX01.diasemi.com> In-Reply-To: <6ED8E3B22081A4459DAC7699F3695FB7A2AFC2F2@SW-EX-MBX01.diasemi.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Opensource [Steve Twiss]" Cc: Guenter Roeck , Jean Delvare , David Dajun Chen , LINUX-DOC , LINUX-KERNEL , LM-SENSORS , Mark Brown , Philipp Zabel , Rob Landley , Samuel Ortiz Wy4uLl0KCj4gPlBsZWFzZSBtYWtlIHN1cmUgdGhhdCBlYWNoIHBhdGNoLCBpZiBhcHBsaWVkIG9u ZSBhZnRlciBhbm90aGVyLCBjb21waWxlcy4KPiA+UGF0Y2ggMS8zIG11c3Qgbm90IGRlcGVuZCBv biBwYXRjaCAyLzMuCj4gCj4gSGkgR3VlbnRlciwKPiAKPiBUaGFuayB5b3UgZm9yIHRoaXMgZmFz dCByZXNwb25zZS4KPiAKPiBBaCwgdGhlIGRlcGVuZGVuY2llcyB3ZXJlIG5vdCBpbiBvcmRlci4g SSB3aWxsIGNoZWNrIGZvciB0aGF0IGluIGZ1dHVyZS4KPiAKPiBJIHdpbGwgYWxzbyBsb29rIGlu dG8gdXNpbmcgdGhlIEFQSSB3aXRoIGRldm1faHdtb25fZGV2aWNlX3JlZ2lzdGVyX3dpdGhfZ3Jv dXBzCj4gYW5kIHdpbGwgcmVzdWJtaXQgd2l0aCBhIFJGQyBWMiBsYXRlci4KCklmIHRoZXJlIGFy ZSBpbnRlci17cGF0Y2gsc3Vic3lzdGVtfSBkZXBlbmRlbmNpZXMgd2l0aGluIGEgcGF0Y2gtc2V0 CnlvdSBuZWVkIHRvIGxldCB1cyBrbm93IHNvIHdlIGNhbiBlbnN1cmUgdGhlIHBhdGNoZXMgYXJl IGtlcHQKdG9nZXRoZXIuIElmIG5vdCB0aGV5IGFyZSBsaWtlbHkgdG8gYmUgc3Vja2VkIGludG8g dGhlaXIgcmVzcGVjdGl2ZQpzdWJzeXN0ZW0gdHJlZXMgYW5kIHdpbGwgYnJlYWsgYmlzZWN0YWJp bGl0eSB3aGVuIHRoZXkgaGl0IE1haW5saW5lLgoKLS0gCkxlZSBKb25lcwpMaW5hcm8gU1RNaWNy b2VsZWN0cm9uaWNzIExhbmRpbmcgVGVhbSBMZWFkCkxpbmFyby5vcmcg4pSCIE9wZW4gc291cmNl IHNvZnR3YXJlIGZvciBBUk0gU29DcwpGb2xsb3cgTGluYXJvOiBGYWNlYm9vayB8IFR3aXR0ZXIg fCBCbG9nCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwps bS1zZW5zb3JzIG1haWxpbmcgbGlzdApsbS1zZW5zb3JzQGxtLXNlbnNvcnMub3JnCmh0dHA6Ly9s aXN0cy5sbS1zZW5zb3JzLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xtLXNlbnNvcnM From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752701AbaCXJYs (ORCPT ); Mon, 24 Mar 2014 05:24:48 -0400 Received: from mail-wg0-f45.google.com ([74.125.82.45]:59040 "EHLO mail-wg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752665AbaCXJYq (ORCPT ); Mon, 24 Mar 2014 05:24:46 -0400 Date: Mon, 24 Mar 2014 09:24:41 +0000 From: Lee Jones To: "Opensource [Steve Twiss]" Cc: Guenter Roeck , Jean Delvare , David Dajun Chen , LINUX-DOC , LINUX-KERNEL , LM-SENSORS , Mark Brown , Philipp Zabel , Rob Landley , Samuel Ortiz Subject: Re: [RFC V1 1/3] hwmon: da9063: HWMON driver Message-ID: <20140324092440.GN8541@lee--X1> References: <420d4f5c8436a66b511693531cfeda131258ce69.1395607051.git.stwiss.opensource@diasemi.com> <532FA8ED.2090201@roeck-us.net> <6ED8E3B22081A4459DAC7699F3695FB7A2AFC2F2@SW-EX-MBX01.diasemi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6ED8E3B22081A4459DAC7699F3695FB7A2AFC2F2@SW-EX-MBX01.diasemi.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [...] > >Please make sure that each patch, if applied one after another, compiles. > >Patch 1/3 must not depend on patch 2/3. > > Hi Guenter, > > Thank you for this fast response. > > Ah, the dependencies were not in order. I will check for that in future. > > I will also look into using the API with devm_hwmon_device_register_with_groups > and will resubmit with a RFC V2 later. If there are inter-{patch,subsystem} dependencies within a patch-set you need to let us know so we can ensure the patches are kept together. If not they are likely to be sucked into their respective subsystem trees and will break bisectability when they hit Mainline. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog