All of lore.kernel.org
 help / color / mirror / Atom feed
From: Don Zickus <dzickus@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@ghostprotocols.net, peterz@infradead.org,
	LKML <linux-kernel@vger.kernel.org>,
	jolsa@redhat.com, jmario@redhat.com, fowles@inreach.com,
	eranian@google.com, andi.kleen@intel.com
Subject: Re: [PATCH 4/6] perf, sort:  Add physid sorting based on mmap2 data
Date: Mon, 24 Mar 2014 16:17:57 -0400	[thread overview]
Message-ID: <20140324201757.GC25953@redhat.com> (raw)
In-Reply-To: <8761n3pe2w.fsf@tassilo.jf.intel.com>

On Mon, Mar 24, 2014 at 12:54:31PM -0700, Andi Kleen wrote:
> Don Zickus <dzickus@redhat.com> writes:
> 
> > In order for the c2c tool to work correctly, it needs to properly
> > sort all the records on uniquely identifiable data addresses.  These
> > unique addresses are converted from virtual addresses provided by the
> > hardware into a kernel address using an mmap2 record as the decoder.
> 
> No documentation for the new option?
> 
> Probably the new mode should be also supported by --sort

I hid the new option further in the changelog, so it isn't obvious.  Sorry
about that.

Sample output: (perf report --stdio --physid-mode)

So the option was '--physid-mode' and if you don't pass in a '--sort' then
it takes the default sort of

'daddr,iaddr,pid,tid,major,minor,inode,inode_gen'

Otherwise you could pass in a combination of the other fields.

The output is not the best way to use the mmap2 data as it just gives you
hottest data addresses.  Our c2c tool really takes the data addresses and
combines them into a cacheline and then processes the cacheline for
interesting bottlenecks (HITMs in our case).

I don't know a good way to present the data and yet still have the sort
useful for our c2c tool.  So I threw this interface together.  I am open
to suggestions.

Cheers,
Don

  reply	other threads:[~2014-03-24 20:18 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-24 19:34 [PATCH 0/6] perf, events: Enable mmap2 support Don Zickus
2014-03-24 19:34 ` [PATCH 1/6] events, perf: Pass protection and flags bits through mmap2 interface Don Zickus
2014-03-24 19:34 ` [PATCH 2/6] perf: Update mmap2 interface with protection and flag bits Don Zickus
2014-04-09  2:17   ` Namhyung Kim
2014-04-09  2:20     ` Namhyung Kim
2014-03-24 19:34 ` [PATCH 3/6] Revert "perf: Disable PERF_RECORD_MMAP2 support" Don Zickus
2014-04-09  2:32   ` Namhyung Kim
2014-03-24 19:34 ` [PATCH 4/6] perf, sort: Add physid sorting based on mmap2 data Don Zickus
2014-03-24 19:54   ` Andi Kleen
2014-03-24 20:17     ` Don Zickus [this message]
2014-03-24 20:20       ` Andi Kleen
2014-03-24 20:26         ` Don Zickus
2014-03-24 20:54   ` [PATCH 01/15 V3] perf: Fix stddev calculation Don Zickus
2014-03-24 20:57     ` Don Zickus
2014-03-24 20:57   ` [PATCH 4/6 V2] perf, sort: Add physid sorting based on mmap2 data Don Zickus
2014-03-29 17:11     ` Jiri Olsa
2014-04-01  2:58       ` Don Zickus
2014-04-09  5:21     ` Namhyung Kim
2014-04-09  5:45       ` Peter Zijlstra
2014-04-09  3:06   ` [PATCH 4/6] " Don Zickus
2014-03-24 19:34 ` [PATCH 5/6] perf: Update sort to handle MAP_SHARED bits Don Zickus
2014-03-24 19:34 ` [PATCH 6/6] perf, sort: Allow unique sorting instead of combining hist_entries Don Zickus
2014-04-09  5:31   ` Namhyung Kim
2014-04-09 13:57     ` Don Zickus
2014-04-10  5:09       ` Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140324201757.GC25953@redhat.com \
    --to=dzickus@redhat.com \
    --cc=acme@ghostprotocols.net \
    --cc=andi.kleen@intel.com \
    --cc=andi@firstfloor.org \
    --cc=eranian@google.com \
    --cc=fowles@inreach.com \
    --cc=jmario@redhat.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.