From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1WSPDb-0000D2-3X for mharc-qemu-trivial@gnu.org; Tue, 25 Mar 2014 07:08:31 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53400) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WSPDT-0008TU-Cn for qemu-trivial@nongnu.org; Tue, 25 Mar 2014 07:08:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WSPDN-0001Ja-6W for qemu-trivial@nongnu.org; Tue, 25 Mar 2014 07:08:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1594) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WSPDA-0001GP-Oj; Tue, 25 Mar 2014 07:08:04 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s2PB7uS7025397 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 25 Mar 2014 07:07:56 -0400 Received: from noname.str.redhat.com (dhcp-192-197.str.redhat.com [10.33.192.197]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with SMTP id s2PB7q4W005182; Tue, 25 Mar 2014 07:07:53 -0400 Date: Tue, 25 Mar 2014 12:07:51 +0100 From: Kevin Wolf To: Prasad Joshi Message-ID: <20140325110751.GD3795@noname.str.redhat.com> References: <1395686334-9498-1-git-send-email-prasadjoshi.linux@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1395686334-9498-1-git-send-email-prasadjoshi.linux@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: qemu-trivial@nongnu.org, pl@kamp.de, qemu-devel@nongnu.org, stefanha@redhat.com, pbonzini@redhat.com, eblake@redhat.com Subject: Re: [Qemu-trivial] [PATCH for-2.0] qemu-img: mandate argument to 'qemu-img check --repair' X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Mar 2014 11:08:29 -0000 Am 24.03.2014 um 19:38 hat Prasad Joshi geschrieben: > qemu-img check --repair option accepts an argument. The argument to > --repair switch can either be 'all' or 'leak'. Fix the long option to > mandate argument with --repair switch. > > The patch fixes following segmentation fault > > Core was generated by `qemu-img check -f qcow2 --repair all t.qcow2'. > Program terminated with signal 11, Segmentation fault. > 0 in img_check (argc=6, argv=0x7fffab9b8a10) at qemu-img.c:588 > 588 if (!strcmp(optarg, "leaks")) { > (gdb) bt > 0 img_check (argc=6, argv=0x7fffab9b8a10) at qemu-img.c:588 > 1 __libc_start_main () from /lib/x86_64-linux-gnu/libc.so.6 > 2 _start () > (gdb) > > Signed-off-by: Prasad Joshi Reviewed-by: Kevin Wolf Stefan, this should still go into 2.0. Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53322) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WSPDH-0008E3-36 for qemu-devel@nongnu.org; Tue, 25 Mar 2014 07:08:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WSPDB-0001Gc-0N for qemu-devel@nongnu.org; Tue, 25 Mar 2014 07:08:11 -0400 Date: Tue, 25 Mar 2014 12:07:51 +0100 From: Kevin Wolf Message-ID: <20140325110751.GD3795@noname.str.redhat.com> References: <1395686334-9498-1-git-send-email-prasadjoshi.linux@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1395686334-9498-1-git-send-email-prasadjoshi.linux@gmail.com> Subject: Re: [Qemu-devel] [PATCH for-2.0] qemu-img: mandate argument to 'qemu-img check --repair' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Prasad Joshi Cc: qemu-trivial@nongnu.org, pl@kamp.de, qemu-devel@nongnu.org, stefanha@redhat.com, pbonzini@redhat.com Am 24.03.2014 um 19:38 hat Prasad Joshi geschrieben: > qemu-img check --repair option accepts an argument. The argument to > --repair switch can either be 'all' or 'leak'. Fix the long option to > mandate argument with --repair switch. > > The patch fixes following segmentation fault > > Core was generated by `qemu-img check -f qcow2 --repair all t.qcow2'. > Program terminated with signal 11, Segmentation fault. > 0 in img_check (argc=6, argv=0x7fffab9b8a10) at qemu-img.c:588 > 588 if (!strcmp(optarg, "leaks")) { > (gdb) bt > 0 img_check (argc=6, argv=0x7fffab9b8a10) at qemu-img.c:588 > 1 __libc_start_main () from /lib/x86_64-linux-gnu/libc.so.6 > 2 _start () > (gdb) > > Signed-off-by: Prasad Joshi Reviewed-by: Kevin Wolf Stefan, this should still go into 2.0. Kevin