From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Andy Whitcroft <apw-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
Cc: "Joe Perches" <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Uwe Kleine-König"
<u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org
Subject: Re: [PATCH v3] i2c: new bus driver for efm32
Date: Tue, 25 Mar 2014 13:00:59 +0100 [thread overview]
Message-ID: <20140325120059.GA2863@katana> (raw)
In-Reply-To: <CAO=4fJM9y6yML77oJ3uW2Wz=nEhm=xA-bKoMHd8DXdxw0z8p7Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 369 bytes --]
On Tue, Mar 25, 2014 at 11:17:49AM +0000, Andy Whitcroft wrote:
> I would call it a false positive and ignore it.=A0 You need to justify any
> reports from checkpatch that remain "this is more readable" seems a valid
> justification.
I agree in general. In this case, I think both options have their pros
and cons in terms of readability, so I let the author decide.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: wsa@the-dreams.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] i2c: new bus driver for efm32
Date: Tue, 25 Mar 2014 13:00:59 +0100 [thread overview]
Message-ID: <20140325120059.GA2863@katana> (raw)
In-Reply-To: <CAO=4fJM9y6yML77oJ3uW2Wz=nEhm=xA-bKoMHd8DXdxw0z8p7Q@mail.gmail.com>
On Tue, Mar 25, 2014 at 11:17:49AM +0000, Andy Whitcroft wrote:
> I would call it a false positive and ignore it.=A0 You need to justify any
> reports from checkpatch that remain "this is more readable" seems a valid
> justification.
I agree in general. In this case, I think both options have their pros
and cons in terms of readability, so I let the author decide.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140325/20c3cbd3/attachment-0001.sig>
next prev parent reply other threads:[~2014-03-25 12:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-21 15:03 [PATCH v3] i2c: new bus driver for efm32 Uwe Kleine-König
2014-03-21 15:03 ` Uwe Kleine-König
[not found] ` <1395414236-22647-1-git-send-email-u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2014-03-24 17:01 ` Wolfram Sang
2014-03-24 17:01 ` Wolfram Sang
2014-03-24 18:41 ` Uwe Kleine-König
2014-03-24 18:41 ` Uwe Kleine-König
[not found] ` <20140324184114.GK23076-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2014-03-24 19:08 ` Wolfram Sang
2014-03-24 19:08 ` Wolfram Sang
2014-03-25 9:07 ` Uwe Kleine-König
2014-03-25 9:07 ` Uwe Kleine-König
[not found] ` <20140325090700.GL23076-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2014-03-25 9:11 ` Wolfram Sang
2014-03-25 9:11 ` Wolfram Sang
[not found] ` <CAO=4fJM9y6yML77oJ3uW2Wz=nEhm=xA-bKoMHd8DXdxw0z8p7Q@mail.gmail.com>
[not found] ` <CAO=4fJM9y6yML77oJ3uW2Wz=nEhm=xA-bKoMHd8DXdxw0z8p7Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-03-25 12:00 ` Wolfram Sang [this message]
2014-03-25 12:00 ` Wolfram Sang
2014-03-25 14:01 ` Joe Perches
2014-03-25 14:01 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140325120059.GA2863@katana \
--to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
--cc=apw-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org \
--cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.