Re: [PATCH] cpio rootfs build: Avoid modifying rootfs dir

[Jonas Eriksson <jonas.eriksson@enea.com>]

Hi Andrea,

On Wed, Mar 26, 2014 at 00:04:55 +0100 Andrea Adami wrote:
> I admit I did not encounter this race, still I tested the patch
> because it caught my attention.
> 
> There are some rare cases where init is a symlink pointing to a custom
> executable so the previous test was specifically done in order to
> avoid to touch a symlink.

Yes, that makes sense. It's however a bit problematic to alter
the rootfs directory after the do_rootfs has finished executing.
This is why the ./init append was moved to work with a separate
directory.

To clarify around the symlink situation: The patch moves from a
-L to a -e to make sure that we don't append the ./init to the
cpio if there is any kind of ./init in the rootfs directory, be
it a file or a symlink.

> I was initially afraid of the change but actually the test is done
> after the creation of the cpio so this patch doesn't seem to break our
> special case.
> 
> Acked-by: Andrea Adami <andrea.adami@gmail.com>

Thanks for the feedback and Ack!

/Jonas